From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: Stefan Weil <sw@weilnetz.de>, QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-tricore: Fix two helper functions (clang warnings)
Date: Sat, 07 Mar 2015 10:44:03 +0000 [thread overview]
Message-ID: <54FAD673.3040106@mail.uni-paderborn.de> (raw)
In-Reply-To: <1425720834-5811-1-git-send-email-sw@weilnetz.de>
Hi Stefan,
On 03/07/2015 09:33 AM, Stefan Weil wrote:
> clang report:
>
> target-tricore/op_helper.c:1247:24: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1248:25: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1249:19: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1297:24: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1298:25: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1299:19: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
>
> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
Good catch. I'm really confused, that this was not breaking my test
suit. Your fix looks good to me at first sight, but I'll look into the
problem.
Cheers,
Bastian
next prev parent reply other threads:[~2015-03-07 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 9:33 [Qemu-devel] [PATCH] target-tricore: Fix two helper functions (clang warnings) Stefan Weil
2015-03-07 10:44 ` Bastian Koppelmann [this message]
2015-03-07 12:34 ` Peter Maydell
2015-03-07 14:36 ` Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FAD673.3040106@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).