From: Eric Blake <eblake@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] 9pfs-proxy: remove one half of redundrand code
Date: Sat, 07 Mar 2015 13:39:33 -0700 [thread overview]
Message-ID: <54FB6205.6020003@redhat.com> (raw)
In-Reply-To: <586e71d1815bde467fbcb2b2878e9fab5c414cd4.1425678142.git.mjt@msgid.tls.msk.ru>
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On 03/06/2015 02:43 PM, Michael Tokarev wrote:
> The 9pfs-proxy code is actually terrible: it does the same
> things again and again, ignoring function arguments and
> re-inventing the same values again, and a lot of code must
> be consistent with each other.
s/redundrand/redundant/ in the subject (a different typo than in 1/3, so
my reply isn't quite redundant :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-07 20:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 21:43 [Qemu-devel] [PATCH v3 0/3] RFC: 9pfs-proxy: simplify/cleanup Michael Tokarev
2015-03-06 21:43 ` [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling Michael Tokarev
2015-03-07 20:37 ` Eric Blake
2015-03-07 22:10 ` Michael Tokarev
2015-03-07 22:11 ` Michael Tokarev
2015-03-08 16:27 ` Aneesh Kumar K.V
2015-03-10 4:23 ` Michael Tokarev
2015-03-10 17:41 ` Aneesh Kumar K.V
2015-03-11 5:58 ` Michael Tokarev
2015-03-11 8:46 ` Aneesh Kumar K.V
2015-03-11 20:05 ` Michael Tokarev
2015-03-11 20:08 ` Michael Tokarev
2015-03-08 16:21 ` Aneesh Kumar K.V
2015-03-06 21:43 ` [Qemu-devel] [PATCH 2/3] fsdev: introduce v9fs_vmarshal() and v9fs_vunmarshal() Michael Tokarev
2015-03-06 21:43 ` [Qemu-devel] [PATCH 3/3] 9pfs-proxy: remove one half of redundrand code Michael Tokarev
2015-03-06 21:46 ` Michael Tokarev
2015-03-07 20:39 ` Eric Blake [this message]
2015-03-10 4:49 ` [Qemu-devel] [PATCH v3 0/3] RFC: 9pfs-proxy: simplify/cleanup Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FB6205.6020003@redhat.com \
--to=eblake@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).