Re: [Qemu-devel] [PATCH v3 4/4] migration: Expose 'cancelling' status to user

[zhanghailiang <zhang.zhanghailiang@huawei.com>]

On 2015/3/7 0:24, Eric Blake wrote:
> On 03/04/2015 07:09 AM, zhanghailiang wrote:
>> 'cancelling' status is introduced by commit 51cf4c1a, which is mainly avoid
>
> s/is introduced/was introduced/
> s/which is mainly avoid/mainly to avoid a/
>
>> possible starting a new migration process while the previous one still exist.
>
> s/starting a new/start of a new/
> s/exist/exists/
>
>> But we don't expose this status to user, instead by return a 'active' state.
>
> s/don't/didn't/
> s/by return a/we returned the/
>
>>
>> Here, we expose it to the user (such as libvirt), 'cancelling' status only
>> occurs for a short window before the migration aborts, so for users,
>> if they cancell a migration process, it will observe 'cancelling' status
>
> s/cancell/cancel/
>
>> occasionally.
>
> Add:
> Testing revealed that with older libvirt (anything 1.2.13 or less) will
> print an odd error message if the state is seen, but that the migration
> is still properly cancelled. Newer libvirt will be patched to recognize
> the new state without the odd error message.
>
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Cc: libvir-list@redhat.com
>> ---
>>   migration/migration.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> With the grammar in the commit message fixed,
> Reviewed-by: Eric Blake <eblake@redhat.com>
>

OK, will fix that in v4, thanks.