From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUrWd-00040y-FQ for qemu-devel@nongnu.org; Mon, 09 Mar 2015 02:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUrWY-0007FA-9T for qemu-devel@nongnu.org; Mon, 09 Mar 2015 02:50:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:34817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUrWY-0007Em-0X for qemu-devel@nongnu.org; Mon, 09 Mar 2015 02:50:46 -0400 Message-ID: <54FD42C2.60509@intel.com> Date: Mon, 09 Mar 2015 14:50:42 +0800 From: "Chen, Tiejun" MIME-Version: 1.0 References: <1425632903-5502-1-git-send-email-tiejun.chen@intel.com> <1425632903-5502-3-git-send-email-tiejun.chen@intel.com> <54F970EC.1030306@intel.com> <20150306125902.GQ12103@zion.uk.xensource.com> In-Reply-To: <20150306125902.GQ12103@zion.uk.xensource.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu Cc: stefano.stabellini@citrix.com, xen-devel@lists.xen.org, Ian.Jackson@eu.citrix.com, ian.campbell@citrix.com, qemu-devel@nongnu.org On 2015/3/6 20:59, Wei Liu wrote: > On Fri, Mar 06, 2015 at 05:18:36PM +0800, Chen, Tiejun wrote: >> On 2015/3/6 17:08, Tiejun Chen wrote: >>> Although we already have 'gfx_passthru' in b_info, this doesn' suffice >>> after we want to handle IGD specifically. Now we define a new field of >>> type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually >>> this means we can benefit this to support other specific devices just >>> by extending gfx_passthru_kind. And then we can cooperate with >>> gfx_passthru to address IGD cases as follows: >>> >>> gfx_passthru = 0 => sets build_info.u.gfx_passthru to false >>> gfx_passthru = 1 => sets build_info.u.gfx_passthru to false and >>> build_info.u.gfx_passthru_kind to DEFAULT >>> gfx_passthru = "igd" => sets build_info.u.gfx_passthru to false >>> and build_info.u.gfx_passthru_kind to IGD >>> >>> Here if gfx_passthru_kind = DEFAULT, we will call >>> libxl__is_igd_vga_passthru() to check if we're hitting that table to need >>> to pass that option to qemu. But if gfx_passthru_kind = "igd" we always >>> force to pass that. >>> >>> Signed-off-by: Tiejun Chen >>> --- >>> tools/libxl/libxl_dm.c | 13 +++++++++++++ >>> tools/libxl/libxl_types.idl | 6 ++++++ >>> tools/libxl/xl_cmdimpl.c | 19 +++++++++++++++++-- >>> 3 files changed, 36 insertions(+), 2 deletions(-) >>> >>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c >>> index 8599a6a..780dd2a 100644 >>> --- a/tools/libxl/libxl_dm.c >>> +++ b/tools/libxl/libxl_dm.c >> >> Sorry, looks I'm missing to remove '-gfx_passthru' since this should be gone >> in the case of qemu upstream, >> >> @@ -710,9 +710,6 @@ static char ** >> libxl__build_device_model_args_new(libxl__gc *gc, >> flexarray_append(dm_args, "-net"); >> flexarray_append(dm_args, "none"); >> } >> - if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { >> - flexarray_append(dm_args, "-gfx_passthru"); >> - } >> } else { >> if (!sdl && !vnc) { >> flexarray_append(dm_args, "-nographic"); >> >> I will fold this into next revision after this review. >> > > I think this change alone warrants a separate changeset. It should be > patch 0 of your series as a preparatory patch. Please remember to > elaborate in commit message why that hunk is not needed in upstream > QEMU. > What about this? "-gfx_passthru" is just introduced to work for qemu-xen-traditional so we should get this away from libxl__build_device_model_args_new() in the case of qemu upstream. Thanks Tiejun