From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YUsgF-0005yy-NC
	for qemu-devel@nongnu.org; Mon, 09 Mar 2015 04:04:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YUsgA-0006xM-VZ
	for qemu-devel@nongnu.org; Mon, 09 Mar 2015 04:04:51 -0400
Message-ID: <54FD53D2.1050405@huawei.com>
Date: Mon, 9 Mar 2015 16:03:30 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1425813387-31231-1-git-send-email-marcel@redhat.com>
	<1425813387-31231-5-git-send-email-marcel@redhat.com>
In-Reply-To: <1425813387-31231-5-git-send-email-marcel@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 for-2.3 04/25] acpi: add aml_lless() term
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, quintela@redhat.com, seabios@seabios.org, agraf@suse.de, alex.williamson@redhat.com, kevin@koconnor.net, mst@redhat.com, kraxel@redhat.com, imammedo@redhat.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, hare@suse.de

On 2015/3/8 19:16, Marcel Apfelbaum wrote:
> Add encoding for ACPI DefLLess Opcode.
> 
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>

Reviewed-by: Shannon Zhao <zhaoshenglong@huawei.com>
> ---
>  hw/acpi/aml-build.c         | 9 +++++++++
>  include/hw/acpi/aml-build.h | 1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index be60f4e..49ba8c1 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -458,6 +458,15 @@ Aml *aml_or(Aml *arg1, Aml *arg2)
>      return var;
>  }
>  
> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefLLess */
> +Aml *aml_lless(Aml *arg1, Aml *arg2)
> +{
> +    Aml *var = aml_opcode(0x95 /* LLessOp */);
> +    aml_append(var, arg1);
> +    aml_append(var, arg2);
> +    return var;
> +}
> +
>  /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefAdd */
>  Aml *aml_add(Aml *arg1, Aml *arg2)
>  {
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 991eacb..edc0520 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -138,6 +138,7 @@ Aml *aml_arg(int pos);
>  Aml *aml_store(Aml *val, Aml *target);
>  Aml *aml_and(Aml *arg1, Aml *arg2);
>  Aml *aml_or(Aml *arg1, Aml *arg2);
> +Aml *aml_lless(Aml *arg1, Aml *arg2);
>  Aml *aml_add(Aml *arg1, Aml *arg2);
>  Aml *aml_notify(Aml *arg1, Aml *arg2);
>  Aml *aml_call1(const char *method, Aml *arg1);
> 


-- 
Thanks,
Shannon