From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUst2-0005t0-Io for qemu-devel@nongnu.org; Mon, 09 Mar 2015 04:18:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUssu-0004cM-Sj for qemu-devel@nongnu.org; Mon, 09 Mar 2015 04:18:04 -0400 Message-ID: <54FD56D5.20200@huawei.com> Date: Mon, 9 Mar 2015 16:16:21 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1425813387-31231-1-git-send-email-marcel@redhat.com> <1425813387-31231-9-git-send-email-marcel@redhat.com> In-Reply-To: <1425813387-31231-9-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 for-2.3 08/25] acpi: add aml_increment() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, quintela@redhat.com, seabios@seabios.org, agraf@suse.de, "Huangpeng (Peter)" , alex.williamson@redhat.com, kevin@koconnor.net, mst@redhat.com, kraxel@redhat.com, imammedo@redhat.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, hare@suse.de On 2015/3/8 19:16, Marcel Apfelbaum wrote: > Add encoding for ACPI DefIncrement Opcode. > > Reviewed-by: Igor Mammedov > Signed-off-by: Marcel Apfelbaum Reviewed-by: Shannon Zhao > --- > hw/acpi/aml-build.c | 8 ++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 09a543c..6315ea0 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -497,6 +497,14 @@ Aml *aml_add(Aml *arg1, Aml *arg2) > return var; > } > > +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefIncrement */ > +Aml *aml_increment(Aml *arg) > +{ > + Aml *var = aml_opcode(0x75 /* IncrementOp */); > + aml_append(var, arg); > + return var; > +} > + > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefIndex */ > Aml *aml_index(Aml *arg1, Aml *idx) > { > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 74a9033..c41f400 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -142,6 +142,7 @@ Aml *aml_shiftleft(Aml *arg1, Aml *count); > Aml *aml_shiftright(Aml *arg1, Aml *count); > Aml *aml_lless(Aml *arg1, Aml *arg2); > Aml *aml_add(Aml *arg1, Aml *arg2); > +Aml *aml_increment(Aml *arg); > Aml *aml_index(Aml *arg1, Aml *idx); > Aml *aml_notify(Aml *arg1, Aml *arg2); > Aml *aml_call1(const char *method, Aml *arg1); >