From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUtu2-0007Z8-GW for qemu-devel@nongnu.org; Mon, 09 Mar 2015 05:23:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUtty-0002Bs-FA for qemu-devel@nongnu.org; Mon, 09 Mar 2015 05:23:10 -0400 Message-ID: <54FD665A.9030905@redhat.com> Date: Mon, 09 Mar 2015 11:22:34 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1425813387-31231-1-git-send-email-marcel@redhat.com> <1425813387-31231-3-git-send-email-marcel@redhat.com> <54FD5288.9050903@huawei.com> In-Reply-To: <54FD5288.9050903@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 for-2.3 02/25] acpi: add aml_or() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, quintela@redhat.com, seabios@seabios.org, agraf@suse.de, "Huangpeng (Peter)" , alex.williamson@redhat.com, kevin@koconnor.net, mst@redhat.com, kraxel@redhat.com, imammedo@redhat.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, hare@suse.de On 03/09/2015 09:58 AM, Shannon Zhao wrote: > On 2015/3/8 19:16, Marcel Apfelbaum wrote: >> Add encoding for ACPI DefOr Opcode. >> >> Reviewed-by: Igor Mammedov >> Signed-off-by: Marcel Apfelbaum >> --- >> hw/acpi/aml-build.c | 10 ++++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 11 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 0d14561..603c0c4 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -448,6 +448,16 @@ Aml *aml_and(Aml *arg1, Aml *arg2) >> return var; >> } >> >> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefOr */ >> +Aml *aml_or(Aml *arg1, Aml *arg2) >> +{ >> + Aml *var = aml_opcode(0x7D /* OrOp */); >> + aml_append(var, arg1); >> + aml_append(var, arg2); >> + build_append_int(var->buf, 0x00); /* NullNameOp */ > Hi, Hi Shannon, thank you for your review. > > I notice that MST has sent a patch which uses build_append_byte instead of build_append_int. > Maybe we can fix this patch before apply. Sure, thank you for bringing this to my attention. Marcel > > Thanks, > Shannon >> + return var; >> +} >> + > >