qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Thomas Huth <thuth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v2 0/2] s390x: Make the s390-ccw BIOS relocatable
Date: Mon, 09 Mar 2015 16:21:40 +0100	[thread overview]
Message-ID: <54FDBA84.4020200@de.ibm.com> (raw)
In-Reply-To: <1425895973-15239-1-git-send-email-thuth@linux.vnet.ibm.com>

Am 09.03.2015 um 11:12 schrieb Thomas Huth:
> Currently, our s390-ccw.img sits at the fix address 126 MiB in memory.
> This has two big disadvantages: 1) We can not start guests with less
> than 128 MiB RAM and 2) if the guest uses a really huge ramdisk > 126 MiB,
> the s390-ccw BIOS gets overwritten and the boot silently crashes.
> 
> These two patches now fix these problems by relocating the s390-ccw
> BIOS to the end of the RAM. The basic idea here is to compile the
> BIOS with the "-fpie" compiler option to create position independent
> code. Sounds easy at a first glance - however, with -fpie, we only
> get position independent _code_ - and a so called GOT (global offset
> table) which contains absolute references to global variables again
> (this is normally needed for supporting dynamic libraries - in our
> s390-ccw BIOS, it's just bad luck that we get a GOT).
> 
> So to be able to really move around our s390-ccw.img in RAM, we've got
> to relocate the entries in the GOT, too. This is what the first patch
> is good for. I've changed the ELF loader there to parse the reloc section
> of the ELF file. I only included the bare minimum of relocation types
> (R_390_RELATIVE) in the patch so far, but this can easily be extended
> in case we need more (with different compiler version etc.).
> 
> The second patch then adds the required changes to the s390-ccw BIOS
> Makefile and our s390 ipl code in QEMU.
> 
> v2:
> - Fixed endianess issues in the ELF relocation function
> 
> Thomas Huth (2):
>   elf-loader: Provide the possibility to relocate s390 ELF files
>   s390/bios: Make the s390-ccw.img relocatable
> 
>  hw/core/loader.c          |    2 +
>  hw/s390x/ipl.c            |   23 ++++++++++++-
>  include/elf.h             |    2 +
>  include/hw/elf_ops.h      |   78 +++++++++++++++++++++++++++++++++++++++++++++
>  pc-bios/s390-ccw/Makefile |   11 +++---
>  5 files changed, 109 insertions(+), 7 deletions(-)
> 

Applied to s390-next.
Thanks

      parent reply	other threads:[~2015-03-09 15:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 10:12 [Qemu-devel] [PATCH v2 0/2] s390x: Make the s390-ccw BIOS relocatable Thomas Huth
2015-03-09 10:12 ` [Qemu-devel] [PATCH v2 1/2] elf-loader: Provide the possibility to relocate s390 ELF files Thomas Huth
2015-03-09 11:11   ` Christian Borntraeger
2015-03-09 13:30     ` Thomas Huth
2015-03-09 13:42       ` Alexander Graf
2015-03-09 10:12 ` [Qemu-devel] [PATCH v2 2/2] s390/bios: Make the s390-ccw.img relocatable Thomas Huth
2015-03-09 15:21 ` Christian Borntraeger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FDBA84.4020200@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=cornelia.huck@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).