From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: Stefan Weil <sw@weilnetz.de>, QEMU Developer <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2] target-tricore: Fix two helper functions (clang warnings)
Date: Mon, 09 Mar 2015 16:14:51 +0000 [thread overview]
Message-ID: <54FDC6FB.9030800@mail.uni-paderborn.de> (raw)
In-Reply-To: <1425739412-8144-1-git-send-email-sw@weilnetz.de>
Hi Stefan,
On 03/07/2015 02:43 PM, Stefan Weil wrote:
> clang report:
>
> target-tricore/op_helper.c:1247:24: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1248:25: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1249:19: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1297:24: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1298:25: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
> target-tricore/op_helper.c:1299:19: warning:
> taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int')
> has no effect [-Wabsolute-value]
>
> Fix also the divisor which was taken from the wrong register
> (thanks to Peter Maydell for this hint).
>
> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> v2 adds the fix for the wrong register.
>
> Stefan
Thanks for the patch. It looks good to me so far. However I would like
to test it on real hardware, to which I don't have access right now and
might take about a week.
Cheers,
Bastian
next prev parent reply other threads:[~2015-03-09 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 14:43 [Qemu-devel] [PATCH v2] target-tricore: Fix two helper functions (clang warnings) Stefan Weil
2015-03-09 16:14 ` Bastian Koppelmann [this message]
2015-03-23 14:41 ` Bastian Koppelmann
2015-03-23 17:36 ` Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FDC6FB.9030800@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).