From: Michael Tokarev <mjt@tls.msk.ru>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1
Date: Tue, 10 Mar 2015 07:19:36 +0300 [thread overview]
Message-ID: <54FE70D8.2010904@msgid.tls.msk.ru> (raw)
In-Reply-To: <87385f4f5v.fsf@linux.vnet.ibm.com>
08.03.2015 19:39, Aneesh Kumar K.V wrote:
> Michael Tokarev <mjt@tls.msk.ru> writes:
>
>> This simplifies code in v9fs_request() a bit by replacing several
>> ifs with a common variable check and rearranging error/cleanup
>> code a bit.
>
> Is this -V2 of
> http://mid.gmane.org/b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git.mjt@msgid.tls.msk.ru
No, this one (simplify v9fs_reqeust(), P1) was a first version.
The above URL points to the v2, a second version.
> I am slightly confused with the patch series. It does split the patch as
> I wanted, but i am not sure which one is the latest, so that i can start
> applying them.
That URL points to last. I merged several small patches into larger ones.
Initially I thought I just plug a small resource leak so the patch will
be small. But the more I understood the code, the bigger the changes
were becoming. So at some point it become unreasonable to keep small
changes since they're related to bigger changes and since bigger changes
touches the same code anyway.
Thanks,
/mjt
next prev parent reply other threads:[~2015-03-10 4:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1425633831-3101-1-git-send-email-mjt@tls.msk.ru>
2015-03-06 9:23 ` [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1 Michael Tokarev
2015-03-08 16:39 ` Aneesh Kumar K.V
2015-03-10 4:19 ` Michael Tokarev [this message]
2015-03-10 4:51 ` Michael Tokarev
2015-03-10 17:31 ` Aneesh Kumar K.V
2015-03-06 9:23 ` [Qemu-devel] [PATCH 2/5] 9pfs-proxy: simplify v9fs_request(), P2 Michael Tokarev
2015-03-06 9:23 ` [Qemu-devel] [PATCH 3/5] 9pfs-proxy: simplify error handling Michael Tokarev
2015-03-06 9:23 ` [Qemu-devel] [PATCH 4/5] 9pfs-proxy: rename a few local variables for consistency Michael Tokarev
2015-03-06 9:23 ` [Qemu-devel] [PATCH 5/5] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FE70D8.2010904@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).