From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43703)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YVEPA-0002wC-HI
	for qemu-devel@nongnu.org; Tue, 10 Mar 2015 03:16:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YVEP9-0001qR-Hd
	for qemu-devel@nongnu.org; Tue, 10 Mar 2015 03:16:40 -0400
Message-ID: <54FE9A16.7000108@huawei.com>
Date: Tue, 10 Mar 2015 15:15:34 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1425966860-13605-1-git-send-email-mjt@msgid.tls.msk.ru>
In-Reply-To: <1425966860-13605-1-git-send-email-mjt@msgid.tls.msk.ru>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] 9pfs-proxy: tiny cleanups in proxy_pwritev
 and proxy_preadv
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>

On 2015/3/10 13:54, Michael Tokarev wrote:
> Don't compare syscall return with -1, use "<0" condition.
> Don't introduce useless local variables when we already
> have similar variable
> Rename local variable to be consistent with other usages
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  hw/9pfs/virtio-9p-proxy.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
> index 59c7445..a01804a 100644
> --- a/hw/9pfs/virtio-9p-proxy.c
> +++ b/hw/9pfs/virtio-9p-proxy.c
> @@ -696,9 +696,9 @@ static ssize_t proxy_preadv(FsContext *ctx, V9fsFidOpenState *fs,
>  #ifdef CONFIG_PREADV
>      return preadv(fs->fd, iov, iovcnt, offset);
>  #else
> -    int err = lseek(fs->fd, offset, SEEK_SET);
> -    if (err == -1) {
> -        return err;
> +    int ret = lseek(fs->fd, offset, SEEK_SET);
> +    if (err < 0)
> +        return ret;

The above code fragment is confused.

Regards,
-Gonglei
>      } else {
>          return readv(fs->fd, iov, iovcnt);
>      }
> @@ -714,10 +714,8 @@ static ssize_t proxy_pwritev(FsContext *ctx, V9fsFidOpenState *fs,
>  #ifdef CONFIG_PREADV
>      ret = pwritev(fs->fd, iov, iovcnt, offset);
>  #else
> -    int err = lseek(fs->fd, offset, SEEK_SET);
> -    if (err == -1) {
> -        return err;
> -    } else {
> +    ret = lseek(fs->fd, offset, SEEK_SET);
> +    if (ret >= 0) {
>          ret = writev(fs->fd, iov, iovcnt);
>      }
>  #endif
>