qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Hajnoczi <stefanha@gmail.com>, Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>,
	qemu-block@nongnu.org, qemu-trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Peter Wu <peter@lekensteyn.nl>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library
Date: Tue, 10 Mar 2015 17:01:38 +0300	[thread overview]
Message-ID: <54FEF942.5010602@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAJSP0QWk+KzGuR2e6m8KsCUbMqcU6cReQbp2231zf9+Nt8zF9g@mail.gmail.com>

10.03.2015 16:58, Stefan Hajnoczi пишет:
> On Tue, Mar 10, 2015 at 10:09 AM, Kevin Wolf <kwolf@redhat.com> wrote:
>> Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben:
>>> On Tue, 03/10 09:50, Kevin Wolf wrote:
>>>> Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben:
>>>> Also, should we consider making some more rarely used image formats
>>>> modules even if they don't pull in external dependencies?
>>>
>>> Sounds reasonable to me. Is the intention to reduce binary size?
>>
>> Yes, that and also that it allows compiling out some drivers without
>> having to mess with the Makefiles. You just don't install all of them.
>>
>> Related to that, Peter also mentioned that you (the user, not developer
>> or packager) could simply disable a single driver, for example as a
>> temporary hotfix in the case of security problems in a block driver.
>> That would actually be an argument for making _all_ drivers modules.
> 
> I am for making all block drivers built as modules.

That might be useful if module loading will be modified a bit,
like by loadin modules on demand only.  Something like this,
search a "foo" block driver in the registered list, found ->
use it, if not, try to open block-foo.so (maybe after looking
in the "available" internal list before that) and look up in
the registered list again.

That will make it more useful.

Thanks,

/mjt

  reply	other threads:[~2015-03-10 14:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  7:06 [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library Michael Tokarev
2015-03-10  8:50 ` Kevin Wolf
2015-03-10  9:17   ` Fam Zheng
2015-03-10 10:09     ` Kevin Wolf
2015-03-10 13:24       ` Markus Armbruster
2015-03-10 13:31         ` Michael Tokarev
2015-03-10 13:59         ` Kevin Wolf
2015-03-10 13:58       ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-03-10 14:01         ` Michael Tokarev [this message]
2015-03-10 14:07           ` Kevin Wolf
2015-03-10 14:38             ` [Qemu-devel] " Michael Tokarev
2015-03-11 13:17               ` Stefan Hajnoczi
2015-03-11 13:06           ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-03-10  9:10 ` [Qemu-devel] " Peter Wu
2015-03-11 13:23 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FEF942.5010602@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter@lekensteyn.nl \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).