qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hmp: Fix texinfo documentation
Date: Tue, 10 Mar 2015 09:27:45 -0600	[thread overview]
Message-ID: <54FF0D71.8050008@redhat.com> (raw)
In-Reply-To: <1425990184-30913-1-git-send-email-armbru@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

On 03/10/2015 06:23 AM, Markus Armbruster wrote:
> Several issues:
> 
> * Commands i and o lack @item.  Their one-liner documentation gets
>   squashed into the preceding command print.  Add the obvious @item.
> 
> * Commands i, o and cpu-add lack @findex.  The function index doesn't
>   have them.  Add the obvious @findex.
> 
> * Commit 727f005 put block_set_io_throttle was added in the middle of
>   block_passwd.  Move it.
> 
> * Correct spelling of commands chardev-add and chardev-remove in @item
>   and @findex.
> 
> * Some commands have a blank line between @item/@findex and the text,
>   most don't.  Normalize to no blank line.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp-commands.hx | 41 +++++++++++++++--------------------------
>  1 file changed, 15 insertions(+), 26 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2015-03-10 15:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 12:23 [Qemu-devel] [PATCH] hmp: Fix texinfo documentation Markus Armbruster
2015-03-10 15:27 ` Eric Blake [this message]
2015-03-17  8:20 ` Markus Armbruster
2015-03-19  8:36 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FF0D71.8050008@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).