From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVM85-0002nI-6O for qemu-devel@nongnu.org; Tue, 10 Mar 2015 11:31:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVM81-0007he-FS for qemu-devel@nongnu.org; Tue, 10 Mar 2015 11:31:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVM81-0007hS-7D for qemu-devel@nongnu.org; Tue, 10 Mar 2015 11:31:29 -0400 Message-ID: <54FF0E27.60303@redhat.com> Date: Tue, 10 Mar 2015 09:30:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-4-git-send-email-dgilbert@redhat.com> In-Reply-To: <1424883128-9841-4-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hXDgnbB1pUtrC1cvuRJtXu3TxBrCEtH5u" Subject: Re: [Qemu-devel] [PATCH v5 03/45] qemu_ram_foreach_block: pass up error value, and down the ramblock name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hXDgnbB1pUtrC1cvuRJtXu3TxBrCEtH5u Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/25/2015 09:51 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > check the return value of the function it calls and error if it's non-0= > Fixup qemu_rdma_init_one_block that is the only current caller, > and __qemu_rdma_add_block the only function it calls using it. Should we also be changing the name of __qemu_rdma_add_block to get rid of the wrong use of the reserved leading __ namespace? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hXDgnbB1pUtrC1cvuRJtXu3TxBrCEtH5u Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU/w4nAAoJEKeha0olJ0NqnegH/0TPSWPyRzVrzMYxtO/6TrXN M0VvMEQ3ysOQDEu+eec/NXIEFNJopTBZ74qbumx4DRN8k73x2+cV8ec5qrVR92wm zliP+WyDG0zvsic8RuhQsAwt656L8DpBsmv/b8OLPPQwMj62zM+mMA3mGysN9ynb /7U/29bVjPAnt7RzXaHMw8yEkkclRuuWkxkd/po8Bu0MQzL3bVwhDZJf/1mrkhpg qxY3/ENgqOVaAlqfUWEFxy1Duz6NvtC/GFy3lNiVK7bjr6XulPkwqbL7K1N0jvPA dHOwpvc5AmNEGnoINbOwk4yMUbfFNqi62h2pP7eLSvgM/4ZkVF/WyFlapQe/ZUk= =MGUy -----END PGP SIGNATURE----- --hXDgnbB1pUtrC1cvuRJtXu3TxBrCEtH5u--