[Qemu-devel] [PATCH] configure: bump glib version to 2.16

[Qemu-devel] [PATCH] configure: bump glib version to 2.16

[John Snow]

Our qtest suite relies on many functions available only in glib 2.16+.
Even though our base QEMU binary may only require 2.12+, it is confusing
to have two separate version requirements.

Thus, this is an attempt to re-establish a sane baseline for the entire
project at 2.16+.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 7ba4bcb..c38506c 100755
--- a/configure
+++ b/configure
@@ -2748,7 +2748,7 @@ if test "$mingw32" = yes; then
     # g_poll is required in order to integrate with the glib main loop.
     glib_req_ver=2.20
 else
-    glib_req_ver=2.12
+    glib_req_ver=2.16
 fi
 glib_modules=gthread-2.0
 if test "$modules" = yes; then
-- 
1.9.3

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

[John Snow]

Adding in Michael Tokarev, I fat-fingered his email address.

On 03/10/2015 01:37 PM, John Snow wrote:
> Our qtest suite relies on many functions available only in glib 2.16+.
> Even though our base QEMU binary may only require 2.12+, it is confusing
> to have two separate version requirements.
>
> Thus, this is an attempt to re-establish a sane baseline for the entire
> project at 2.16+.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7ba4bcb..c38506c 100755
> --- a/configure
> +++ b/configure
> @@ -2748,7 +2748,7 @@ if test "$mingw32" = yes; then
>       # g_poll is required in order to integrate with the glib main loop.
>       glib_req_ver=2.20
>   else
> -    glib_req_ver=2.12
> +    glib_req_ver=2.16
>   fi
>   glib_modules=gthread-2.0
>   if test "$modules" = yes; then
>

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

[Peter Maydell]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

On 10 March 2015 at 17:37, John Snow <jsnow@redhat.com> wrote:

> Our qtest suite relies on many functions available only in glib 2.16+.
> Even though our base QEMU binary may only require 2.12+, it is confusing
> to have two separate version requirements.
>
> Thus, this is an attempt to re-establish a sane baseline for the entire
> project at 2.16+.
>


Why 2.16 rather than the 2.22 that we seem to have converged
on in discussions on-list?

-- PMM

[-- Attachment #2: Type: text/html, Size: 827 bytes --]

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

[John Snow]

On 03/10/2015 01:41 PM, Peter Maydell wrote:
>
>
> On 10 March 2015 at 17:37, John Snow <jsnow@redhat.com
> <mailto:jsnow@redhat.com>> wrote:
>
>     Our qtest suite relies on many functions available only in glib 2.16+.
>     Even though our base QEMU binary may only require 2.12+, it is confusing
>     to have two separate version requirements.
>
>     Thus, this is an attempt to re-establish a sane baseline for the entire
>     project at 2.16+.
>
>
>
> Why 2.16 rather than the 2.22 that we seem to have converged
> on in discussions on-list?
>
> -- PMM
>

Wasn't aware we were actually going through with that; it had looked 
like we were going to refrain from fiddling with it because we found a 
workaround that sufficed for glib 2.12.

2.16 is just the minimum that qtests currently actually requires.

If, however, we *are* going to shoot for 2.22, then NACK this and let's 
do that instead.

--js

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

[Peter Maydell]

On 10 March 2015 at 17:43, John Snow <jsnow@redhat.com> wrote:
> Wasn't aware we were actually going through with that; it had looked
> like we were going to refrain from fiddling with it because we found
> a workaround that sufficed for glib 2.12.

Well, we're not doing anything before QEMU 2.3 is released.
But if we bump the version requirement at all, then we might
as well move it to 2.22, because once you drop the "support RHEL5"
requirement then that's the newest version we can shift to without
breaking compilation on some other distro we care about (SUSE, in
this case).

-- PMM

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

[Peter Maydell]

On 10 March 2015 at 17:45, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 10 March 2015 at 17:43, John Snow <jsnow@redhat.com> wrote:
>> Wasn't aware we were actually going through with that; it had looked
>> like we were going to refrain from fiddling with it because we found
>> a workaround that sufficed for glib 2.12.
>
> Well, we're not doing anything before QEMU 2.3 is released.
> But if we bump the version requirement at all, then we might
> as well move it to 2.22, because once you drop the "support RHEL5"
> requirement then that's the newest version we can shift to without
> breaking compilation on some other distro we care about (SUSE, in
> this case).

So do people still want to bump the minimum glib version?
If we're going to do it for 2.4 I would prefer to see the
configure patch reasonably early in the release cycle I think.

-- PMM

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

[John Snow]

On 05/07/2015 08:22 AM, Peter Maydell wrote:
> On 10 March 2015 at 17:45, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 10 March 2015 at 17:43, John Snow <jsnow@redhat.com> wrote:
>>> Wasn't aware we were actually going through with that; it had looked
>>> like we were going to refrain from fiddling with it because we found
>>> a workaround that sufficed for glib 2.12.
>>
>> Well, we're not doing anything before QEMU 2.3 is released.
>> But if we bump the version requirement at all, then we might
>> as well move it to 2.22, because once you drop the "support RHEL5"
>> requirement then that's the newest version we can shift to without
>> breaking compilation on some other distro we care about (SUSE, in
>> this case).
> 
> So do people still want to bump the minimum glib version?
> If we're going to do it for 2.4 I would prefer to see the
> configure patch reasonably early in the release cycle I think.
> 
> -- PMM
> 

I think we determined that the minimum version could be as high as 2.22.

https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg00488.html

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

[Markus Armbruster]

John Snow <jsnow@redhat.com> writes:

> On 05/07/2015 08:22 AM, Peter Maydell wrote:
>> On 10 March 2015 at 17:45, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> On 10 March 2015 at 17:43, John Snow <jsnow@redhat.com> wrote:
>>>> Wasn't aware we were actually going through with that; it had looked
>>>> like we were going to refrain from fiddling with it because we found
>>>> a workaround that sufficed for glib 2.12.
>>>
>>> Well, we're not doing anything before QEMU 2.3 is released.
>>> But if we bump the version requirement at all, then we might
>>> as well move it to 2.22, because once you drop the "support RHEL5"
>>> requirement then that's the newest version we can shift to without
>>> breaking compilation on some other distro we care about (SUSE, in
>>> this case).
>> 
>> So do people still want to bump the minimum glib version?
>> If we're going to do it for 2.4 I would prefer to see the
>> configure patch reasonably early in the release cycle I think.
>> 
>> -- PMM
>> 
>
> I think we determined that the minimum version could be as high as 2.22.
>
> https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg00488.html

I support upgrading to a more recent version of GLib as much as ever.
Let's go for 2.22.