From: "Andreas Färber" <afaerber@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user
Date: Tue, 10 Mar 2015 18:53:23 +0100 [thread overview]
Message-ID: <54FF2F93.9050300@suse.de> (raw)
In-Reply-To: <20150310184052-mutt-send-email-mst@redhat.com>
Am 10.03.2015 um 18:41 schrieb Michael S. Tsirkin:
> On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas Färber wrote:
>> Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin:
>>> Make it safe to include hw/boards.h in exec.c
>>> for linux-user configurations.
>>> We don't need any of its contents though.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>>
>>> Already on my tree as Marcel's patches needed this.
>>
>> Why? Which patches?
>>
>> Andreas
>
> This one:
> machine: query dump-guest-core machine property rather than qemu opts
Let's please find a better way to fix that. hw/boards.h shouldn't be
used outside softmmu code.
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-03-10 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 17:33 [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user Michael S. Tsirkin
2015-03-10 17:34 ` Andreas Färber
2015-03-10 17:41 ` Michael S. Tsirkin
2015-03-10 17:53 ` Andreas Färber [this message]
2015-03-10 18:04 ` Peter Maydell
2015-03-10 21:22 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FF2F93.9050300@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).