From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVV7U-0001M3-JQ for qemu-devel@nongnu.org; Tue, 10 Mar 2015 21:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVV7Q-0007JU-08 for qemu-devel@nongnu.org; Tue, 10 Mar 2015 21:07:32 -0400 Message-ID: <54FF950D.8070502@huawei.com> Date: Wed, 11 Mar 2015 09:06:21 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1425813387-31231-1-git-send-email-marcel@redhat.com> <1425813387-31231-12-git-send-email-marcel@redhat.com> <20150310170703.GA23725@redhat.com> <54FF2935.1000207@redhat.com> <20150310183808-mutt-send-email-mst@redhat.com> In-Reply-To: <20150310183808-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 for-2.3 11/25] hw/apci: add _PRT method for extra PCI root busses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Marcel Apfelbaum Cc: Hangaohuai , quintela@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, agraf@suse.de, alex.williamson@redhat.com, kevin@koconnor.net, qemu-ppc@nongnu.org, kraxel@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, imammedo@redhat.com, "Huangpeng (Peter)" , rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, hare@suse.de On 2015/3/11 1:40, Michael S. Tsirkin wrote: > On Tue, Mar 10, 2015 at 07:26:13PM +0200, Marcel Apfelbaum wrote: >> > On 03/10/2015 07:07 PM, Michael S. Tsirkin wrote: >>> > >On Sun, Mar 08, 2015 at 01:16:13PM +0200, Marcel Apfelbaum wrote: >>>> > >>Signed-off-by: Marcel Apfelbaum >>>> > >>--- >>>> > >> hw/i386/acpi-build.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> > >> 1 file changed, 65 insertions(+) >>>> > >> >>>> > >>diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c >>>> > >>index e5709e8..e7a1a36 100644 >>>> > >>--- a/hw/i386/acpi-build.c >>>> > >>+++ b/hw/i386/acpi-build.c >>>> > >>@@ -664,6 +664,70 @@ static void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus, >>>> > >> aml_append(parent_scope, method); >>>> > >> } >>>> > >> >>>> > >>+static Aml *build_link(Aml *lnk, Aml *lnk_pkg, const char *link_name, int idx) >>> > > >>> > >Pls document arguments, and generally make this function >>> > >more readable. >> > I'll think of something >> > >>> > > >>>> > >>+{ >>>> > >>+ Aml *if_ctx, *pkg; >>>> > >>+ >>>> > >>+ if_ctx = aml_if(aml_equal(lnk, aml_int(idx))); >>>> > >>+ pkg = aml_package(4); >>> > > >>> > >These assignments can be part of declarations. >> > OK >> > >>> > > >>>> > >>+ aml_append(pkg, aml_int(0)); >>>> > >>+ aml_append(pkg, aml_int(0)); >>>> > >>+ aml_append(pkg, aml_name(link_name, "")); >>> > > >>> > >this sould be aml_name(link_name) I think? >> > It doesn't work without the "" agument, works only for literals. >> > If you have any idea how to make it work, I'll be glad to change it. > So use "%s" format then. > Yes, use aml_name("%s", link_name) it should work. -- Thanks, Shannon