From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVVIg-0004Mr-K0 for qemu-devel@nongnu.org; Tue, 10 Mar 2015 21:19:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVVIc-0003Jn-Kg for qemu-devel@nongnu.org; Tue, 10 Mar 2015 21:19:06 -0400 Message-ID: <54FF97C3.8060909@huawei.com> Date: Wed, 11 Mar 2015 09:17:55 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1426001534-7151-1-git-send-email-marcel@redhat.com> <1426001534-7151-3-git-send-email-marcel@redhat.com> In-Reply-To: <1426001534-7151-3-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 for-2.3 02/28] acpi: add aml_or() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: Hangaohuai , pbonzini@redhat.com, quintela@redhat.com, seabios@seabios.org, agraf@suse.de, "Huangpeng (Peter)" , alex.williamson@redhat.com, kevin@koconnor.net, mst@redhat.com, kraxel@redhat.com, imammedo@redhat.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, hare@suse.de On 2015/3/10 23:31, Marcel Apfelbaum wrote: > Add encoding for ACPI DefOr Opcode. > > Reviewed-by: Shannon Zhao > Reviewed-by: Igor Mammedov > Signed-off-by: Marcel Apfelbaum > --- > hw/acpi/aml-build.c | 10 ++++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index ace180b..db8d346 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -452,6 +452,16 @@ Aml *aml_and(Aml *arg1, Aml *arg2) > return var; > } > > +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefOr */ > +Aml *aml_or(Aml *arg1, Aml *arg2) > +{ > + Aml *var = aml_opcode(0x7D /* OrOp */); > + aml_append(var, arg1); > + aml_append(var, arg2); > + build_append_int(var->buf, 0x00); /* NullNameOp */ Maybe you forgot to fix this. Same with patch 03, 05, 06, 07. Thanks, Shannon > + return var; > +} > + > /* ACPI 1.0b: 16.2.5.3 Type 1 Opcodes Encoding: DefNotify */ > Aml *aml_notify(Aml *arg1, Aml *arg2) > { > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 17d3beb..c0eb691 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -137,6 +137,7 @@ Aml *aml_int(const uint64_t val); > Aml *aml_arg(int pos); > Aml *aml_store(Aml *val, Aml *target); > Aml *aml_and(Aml *arg1, Aml *arg2); > +Aml *aml_or(Aml *arg1, Aml *arg2); > Aml *aml_notify(Aml *arg1, Aml *arg2); > Aml *aml_call1(const char *method, Aml *arg1); > Aml *aml_call2(const char *method, Aml *arg1, Aml *arg2); >