* [Qemu-devel] [PATCH] nbd: Fix overflow return value
@ 2015-02-12 6:21 Yik Fang
2015-02-12 7:38 ` Fam Zheng
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Yik Fang @ 2015-02-12 6:21 UTC (permalink / raw)
To: qemu-devel
Cc: famz, stefanha, kathy.wangting, Yik Fang, boby.chen,
rudy.zhangmin, wu.wubin
The value of reply.error should be the type unsigned int.
Signed-off-by: Yik Fang <eric.fangyi@huawei.com>
---
nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd.c b/nbd.c
index e56afbc1..30e2f3b 100644
--- a/nbd.c
+++ b/nbd.c
@@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
default:
LOG("invalid request type (%u) received", request.type);
invalid_request:
- reply.error = -EINVAL;
+ reply.error = EINVAL;
error_reply:
if (nbd_co_send_reply(req, &reply, 0) < 0) {
goto out;
--
1.8.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
2015-02-12 6:21 [Qemu-devel] [PATCH] nbd: Fix overflow return value Yik Fang
@ 2015-02-12 7:38 ` Fam Zheng
2015-03-02 1:25 ` Fangyi (C)
2015-03-11 11:39 ` Paolo Bonzini
2 siblings, 0 replies; 7+ messages in thread
From: Fam Zheng @ 2015-02-12 7:38 UTC (permalink / raw)
To: Yik Fang
Cc: stefanha, kathy.wangting, qemu-devel, boby.chen, rudy.zhangmin,
wu.wubin
On Thu, 02/12 06:21, Yik Fang wrote:
> The value of reply.error should be the type unsigned int.
>
> Signed-off-by: Yik Fang <eric.fangyi@huawei.com>
> ---
> nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nbd.c b/nbd.c
> index e56afbc1..30e2f3b 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
> default:
> LOG("invalid request type (%u) received", request.type);
> invalid_request:
> - reply.error = -EINVAL;
> + reply.error = EINVAL;
> error_reply:
> if (nbd_co_send_reply(req, &reply, 0) < 0) {
> goto out;
> --
> 1.8.5
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* [Qemu-devel] [PATCH] nbd: Fix overflow return value
2015-02-12 6:21 [Qemu-devel] [PATCH] nbd: Fix overflow return value Yik Fang
2015-02-12 7:38 ` Fam Zheng
@ 2015-03-02 1:25 ` Fangyi (C)
2015-03-02 9:48 ` Markus Armbruster
2015-03-09 2:16 ` Yik Fang
2015-03-11 11:39 ` Paolo Bonzini
2 siblings, 2 replies; 7+ messages in thread
From: Fangyi (C) @ 2015-03-02 1:25 UTC (permalink / raw)
To: qemu-devel@nongnu.org
Cc: famz, stefanha, kathy.wangting, boby.chen, rudy.zhangmin,
wu.wubin
PING
The value of reply.error should be the type unsigned int.
Signed-off-by: Yik Fang <eric.fangyi@huawei.com>
---
nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd.c b/nbd.c
index e56afbc1..30e2f3b 100644
--- a/nbd.c
+++ b/nbd.c
@@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
default:
LOG("invalid request type (%u) received", request.type);
invalid_request:
- reply.error = -EINVAL;
+ reply.error = EINVAL;
error_reply:
if (nbd_co_send_reply(req, &reply, 0) < 0) {
goto out;
-- 1.8.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
2015-03-02 1:25 ` Fangyi (C)
@ 2015-03-02 9:48 ` Markus Armbruster
2015-03-09 2:16 ` Yik Fang
1 sibling, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2015-03-02 9:48 UTC (permalink / raw)
To: Fangyi (C)
Cc: famz, stefanha, kathy.wangting, qemu-devel@nongnu.org, boby.chen,
Paolo Bonzini, rudy.zhangmin, wu.wubin
"Fangyi (C)" <bruce.fon@huawei.com> writes:
> PING
Please drop this line, it doesn't belong to the commit message.
You copied a bunch of people, but forgot the maintainer:
$ scripts/get_maintainer.pl -f nbd.c
Paolo Bonzini <pbonzini@redhat.com> (odd fixer:Network Block Dev...)
I fixed that for you.
> The value of reply.error should be the type unsigned int.
>
> Signed-off-by: Yik Fang <eric.fangyi@huawei.com>
> ---
> nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nbd.c b/nbd.c
> index e56afbc1..30e2f3b 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
> default:
> LOG("invalid request type (%u) received", request.type);
> invalid_request:
> - reply.error = -EINVAL;
> + reply.error = EINVAL;
> error_reply:
> if (nbd_co_send_reply(req, &reply, 0) < 0) {
> goto out;
> -- 1.8.5
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
2015-03-02 1:25 ` Fangyi (C)
2015-03-02 9:48 ` Markus Armbruster
@ 2015-03-09 2:16 ` Yik Fang
2015-03-11 1:27 ` Yik Fang
1 sibling, 1 reply; 7+ messages in thread
From: Yik Fang @ 2015-03-09 2:16 UTC (permalink / raw)
To: armbru, qemu-devel; +Cc: pbonzini
Thanks to Markus for your help!
On 2015/3/2 9:25, Fangyi (C) wrote:
> PING
> The value of reply.error should be the type unsigned int.
>
> Signed-off-by: Yik Fang <eric.fangyi@huawei.com>
> ---
> nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nbd.c b/nbd.c
> index e56afbc1..30e2f3b 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
> default:
> LOG("invalid request type (%u) received", request.type);
> invalid_request:
> - reply.error = -EINVAL;
> + reply.error = EINVAL;
> error_reply:
> if (nbd_co_send_reply(req, &reply, 0) < 0) {
> goto out;
> -- 1.8.5
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
2015-03-09 2:16 ` Yik Fang
@ 2015-03-11 1:27 ` Yik Fang
0 siblings, 0 replies; 7+ messages in thread
From: Yik Fang @ 2015-03-11 1:27 UTC (permalink / raw)
To: Pbonzini, qemu-devel
Paolo,
Can you have a look at this patch, and give me some advices?
Regards,
Yik Fang
-------- 转发的消息 --------
主题: Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
日期: Mon, 9 Mar 2015 10:16:07 +0800
发件人: Yik Fang <eric.fangyi@huawei.com>
收件人: armbru@redhat.com, qemu-devel@nongnu.org
抄送: pbonzini@redhat.com
Thanks to Markus for your help!
On 2015/3/2 9:25, Fangyi (C) wrote:
> PING
> The value of reply.error should be the type unsigned int.
>
> Signed-off-by: Yik Fang <eric.fangyi@huawei.com>
> ---
> nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nbd.c b/nbd.c
> index e56afbc1..30e2f3b 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
> default:
> LOG("invalid request type (%u) received", request.type);
> invalid_request:
> - reply.error = -EINVAL;
> + reply.error = EINVAL;
> error_reply:
> if (nbd_co_send_reply(req, &reply, 0) < 0) {
> goto out;
> -- 1.8.5
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
2015-02-12 6:21 [Qemu-devel] [PATCH] nbd: Fix overflow return value Yik Fang
2015-02-12 7:38 ` Fam Zheng
2015-03-02 1:25 ` Fangyi (C)
@ 2015-03-11 11:39 ` Paolo Bonzini
2 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2015-03-11 11:39 UTC (permalink / raw)
To: Yik Fang, qemu-devel
Cc: famz, stefanha, kathy.wangting, boby.chen, rudy.zhangmin,
wu.wubin
On 12/02/2015 07:21, Yik Fang wrote:
> The value of reply.error should be the type unsigned int.
>
> Signed-off-by: Yik Fang <eric.fangyi@huawei.com>
> ---
> nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nbd.c b/nbd.c
> index e56afbc1..30e2f3b 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
> default:
> LOG("invalid request type (%u) received", request.type);
> invalid_request:
> - reply.error = -EINVAL;
> + reply.error = EINVAL;
> error_reply:
> if (nbd_co_send_reply(req, &reply, 0) < 0) {
> goto out;
>
Applied to my local branch, thanks.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-11 11:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-12 6:21 [Qemu-devel] [PATCH] nbd: Fix overflow return value Yik Fang
2015-02-12 7:38 ` Fam Zheng
2015-03-02 1:25 ` Fangyi (C)
2015-03-02 9:48 ` Markus Armbruster
2015-03-09 2:16 ` Yik Fang
2015-03-11 1:27 ` Yik Fang
2015-03-11 11:39 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).