From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Michael S . Tsirkin" <mst@redhat.com>
Cc: "open list:IDE" <qemu-block@nongnu.org>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 20/21] hw/ide: Remove unused include
Date: Tue, 29 May 2018 13:35:02 +0200 [thread overview]
Message-ID: <54a3e4cc-86d8-47b4-26ff-290fbd76da41@redhat.com> (raw)
In-Reply-To: <20180528232719.4721-21-f4bug@amsat.org>
On 29.05.2018 01:27, Philippe Mathieu-Daudé wrote:
> There is no need to include pci.h in this file.
> (Continue f23c81073a cleanup).
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/ide/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index 866c659498..cc9ca28c33 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -25,7 +25,6 @@
>
> #include "qemu/osdep.h"
> #include "hw/hw.h"
> -#include "hw/pci/pci.h"
> #include "hw/isa/isa.h"
> #include "qemu/error-report.h"
> #include "qemu/timer.h"
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-05-29 11:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 23:26 [Qemu-devel] [PATCH v4 00/21] Includes cleanup Philippe Mathieu-Daudé
2018-05-28 23:26 ` [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file Philippe Mathieu-Daudé
2018-05-28 23:48 ` Alex Williamson
2018-05-29 0:06 ` Michael S. Tsirkin
2018-05-29 0:36 ` Philippe Mathieu-Daudé
2018-05-29 9:53 ` Cornelia Huck
2018-05-29 10:45 ` Paolo Bonzini
2018-05-29 13:09 ` Alex Williamson
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 02/21] accel: Do not include "exec/address-spaces.h" if it is not necessary Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 03/21] target: " Philippe Mathieu-Daudé
2018-05-29 10:05 ` Cornelia Huck
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 04/21] memory: Do not include "exec/ioport.h" " Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 05/21] target/i386: " Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 06/21] target/xtensa: Include "qemu/timer.h" to use NANOSECONDS_PER_SECOND Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 07/21] target/ppc: Include "exec/exec-all.h" which provides tlb_flush() Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 08/21] target/hppa: Include "qemu/log.h" to use qemu_log() Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary Philippe Mathieu-Daudé
2018-05-29 11:40 ` Cornelia Huck
2018-05-30 3:12 ` Philippe Mathieu-Daudé
2018-05-30 4:42 ` Michael S. Tsirkin
2018-05-30 5:50 ` Philippe Mathieu-Daudé
2018-05-30 6:19 ` Philippe Mathieu-Daudé
2018-05-30 12:55 ` Michael S. Tsirkin
2018-05-30 9:32 ` Paolo Bonzini
2018-05-30 10:12 ` Cornelia Huck
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 10/21] hw: Do not include "exec/ioport.h" " Philippe Mathieu-Daudé
2018-05-29 7:59 ` Marcel Apfelbaum
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 11/21] hw: Do not include "exec/address-spaces.h" " Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 12/21] hw: Do not include "sysemu/block-backend.h" " Philippe Mathieu-Daudé
2018-05-29 10:14 ` Cornelia Huck
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 13/21] hw: Do not include "sysemu/blockdev.h" " Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 14/21] " Philippe Mathieu-Daudé
2018-05-29 11:03 ` Cornelia Huck
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 15/21] hw/block/nvme: Include "qemu/cutils.h" directly in the source file Philippe Mathieu-Daudé
2018-05-29 0:42 ` Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 16/21] hw/misc/mips_itu: Cleanup includes Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 17/21] hw/misc/sga: Use the correct ISA include Philippe Mathieu-Daudé
2018-05-29 7:58 ` Marcel Apfelbaum
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 18/21] hw/hppa: Remove unused include Philippe Mathieu-Daudé
2018-05-29 11:27 ` Thomas Huth
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 19/21] hw/i386/pc: " Philippe Mathieu-Daudé
2018-05-29 7:58 ` Marcel Apfelbaum
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 20/21] hw/ide: " Philippe Mathieu-Daudé
2018-05-29 11:35 ` Thomas Huth [this message]
2018-05-30 20:29 ` John Snow
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 21/21] hw: Clean "hw/devices.h" includes Philippe Mathieu-Daudé
2018-05-29 0:07 ` [Qemu-devel] [PATCH v4 00/21] Includes cleanup Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54a3e4cc-86d8-47b4-26ff-290fbd76da41@redhat.com \
--to=thuth@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).