From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [PATCH 6/6] target/arm: Restrict TCG cpus to TCG accel
Date: Wed, 22 Apr 2020 08:58:34 +0200 [thread overview]
Message-ID: <54a52306-1e7a-768f-637d-dd29f48196ce@redhat.com> (raw)
In-Reply-To: <e2864e76-90a7-03f6-7bf0-e409980a2900@linaro.org>
On 4/22/20 6:24 AM, Richard Henderson wrote:
> On 4/21/20 6:19 AM, Philippe Mathieu-Daudé wrote:
>> A KVM-only build won't be able to run TCG cpus.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> This patch review is funnier using:
>> 'git-diff --color-moved=dimmed-zebra'
>> ---
>> target/arm/cpu.c | 634 -------------------------------------
>> target/arm/cpu_tcg.c | 663 +++++++++++++++++++++++++++++++++++++++
>> target/arm/Makefile.objs | 1 +
>> 3 files changed, 664 insertions(+), 634 deletions(-)
>> create mode 100644 target/arm/cpu_tcg.c
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Thank you Richard for reviewing 6 different time the same code movement...!
next prev parent reply other threads:[~2020-04-22 6:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 13:19 [PATCH 0/6] target/arm: Restrict TCG cpus to TCG accel Philippe Mathieu-Daudé
2020-04-21 13:19 ` [PATCH 1/6] target/arm: Restric the Address Translate write operation " Philippe Mathieu-Daudé
2020-04-22 4:13 ` Richard Henderson
2020-04-21 13:19 ` [PATCH 2/6] target/arm: Make set_feature() available for other files Philippe Mathieu-Daudé
2020-04-23 7:23 ` Philippe Mathieu-Daudé
2020-04-21 13:19 ` [PATCH 3/6] target/arm: Make cpu_register() " Philippe Mathieu-Daudé
2020-04-21 13:19 ` [PATCH 4/6] target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPUInfo[] Philippe Mathieu-Daudé
2020-04-22 4:16 ` Richard Henderson
2020-04-21 13:19 ` [PATCH 5/6] target/arm/cpu: Update coding style to make checkpatch.pl happy Philippe Mathieu-Daudé
2020-04-22 4:17 ` Richard Henderson
2020-04-21 13:19 ` [PATCH 6/6] target/arm: Restrict TCG cpus to TCG accel Philippe Mathieu-Daudé
2020-04-22 4:24 ` Richard Henderson
2020-04-22 6:58 ` Philippe Mathieu-Daudé [this message]
2020-04-22 6:57 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54a52306-1e7a-768f-637d-dd29f48196ce@redhat.com \
--to=philmd@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).