From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjNPK-00038d-8y for qemu-devel@nongnu.org; Mon, 03 Jun 2013 01:34:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjNPG-0008E5-Ne for qemu-devel@nongnu.org; Mon, 03 Jun 2013 01:34:14 -0400 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:37851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjNPG-0008Dr-HT for qemu-devel@nongnu.org; Mon, 03 Jun 2013 01:34:10 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb1so129629pad.37 for ; Sun, 02 Jun 2013 22:34:09 -0700 (PDT) Sender: Peter Crosthwaite From: peter.crosthwaite@xilinx.com Date: Mon, 3 Jun 2013 15:32:42 +1000 Message-Id: <54b43e8b5fe6acff6fe667062d412c0b224f92f6.1370237352.git.peter.crosthwaite@xilinx.com> In-Reply-To: References: Subject: [Qemu-devel] [PATCH v1 2/3] memory: as_update_topology_pass: Improve comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, edgar.iglesias@gmail.com From: Peter Crosthwaite These comments we're a little difficult to read. First one had incorrect parenthesis. The part about attributes changing is really applicable to the region being 'in both' rather than 'in new' Second comment has an obscure parenthetic about 'Logging may have changed'. Made clearer, as this if is supposed to handle the case where the memory region is unchanged (with the notable exception re logging). Signed-off-by: Peter Crosthwaite --- memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 60e033b..7e710c4 100644 --- a/memory.c +++ b/memory.c @@ -719,7 +719,7 @@ static void address_space_update_topology_pass(AddressSpace *as, || int128_lt(frold->addr.start, frnew->addr.start) || (int128_eq(frold->addr.start, frnew->addr.start) && !flatrange_equal(frold, frnew)))) { - /* In old, but (not in new, or in new but attributes changed). */ + /* In old but not in new, or in both but attributes changed. */ if (!adding) { MEMORY_LISTENER_UPDATE_REGION(frold, as, Reverse, region_del); @@ -727,7 +727,7 @@ static void address_space_update_topology_pass(AddressSpace *as, ++iold; } else if (frold && frnew && flatrange_equal(frold, frnew)) { - /* In both (logging may have changed) */ + /* In both and unchanged (except logging may have changed) */ if (adding) { MEMORY_LISTENER_UPDATE_REGION(frnew, as, Forward, region_nop); -- 1.8.3.rc1.44.gb387c77.dirty