From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D3EC433DB for ; Mon, 4 Jan 2021 19:39:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8A1221919 for ; Mon, 4 Jan 2021 19:39:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8A1221919 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=siduction.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwVhL-0007S2-Hm for qemu-devel@archiver.kernel.org; Mon, 04 Jan 2021 14:39:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwVgI-0006xJ-DJ for qemu-devel@nongnu.org; Mon, 04 Jan 2021 14:38:18 -0500 Received: from www226.your-server.de ([188.40.28.6]:50056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwVg9-0006uz-VH for qemu-devel@nongnu.org; Mon, 04 Jan 2021 14:38:18 -0500 Received: from sslproxy01.your-server.de ([78.46.139.224]) by www226.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1kwVfu-000EZg-Cq; Mon, 04 Jan 2021 20:37:54 +0100 Received: from [31.16.171.184] (helo=[192.168.178.10]) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwVfu-0000sr-7y; Mon, 04 Jan 2021 20:37:54 +0100 Subject: Re: [BUG] qemu git error with virgl To: Igor Mammedov References: <30eb4fc7-ef1f-4e92-4e1f-46b71ae8d9f0@siduction.org> <20210104195055.7d60dbc4@redhat.com> From: Torsten Wohlfarth Message-ID: <54ca995e-d7b4-d278-cc6c-019bcbef4dfd@siduction.org> Date: Mon, 4 Jan 2021 20:37:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210104195055.7d60dbc4@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated-Sender: towo@siduction.org X-Virus-Scanned: Clear (ClamAV 0.102.4/26038/Mon Jan 4 13:38:27 2021) Received-SPF: none client-ip=188.40.28.6; envelope-from=towo@siduction.org; helo=www226.your-server.de X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Igor, yes, that fixes my issue. Regards, Torsten Am 04.01.21 um 19:50 schrieb Igor Mammedov: > On Sun, 3 Jan 2021 18:28:11 +0100 > Philippe Mathieu-Daudé wrote: > >> Cc'ing Gerd + patch author/reviewer. >> >> On 1/2/21 2:11 PM, Torsten Wohlfarth wrote: >>> Hello, >>> >>> i can't start any system if i use virgl. I get the following error: >>> >>> qemu-x86_64: ../ui/console.c:1791: dpy_gl_ctx_create: Assertion >>> `con->gl' failed. > Does following fix issue: > [PULL 12/55] vl: initialize displays _after_ exiting preconfiguration > >>> ./and.sh: line 27: 3337167 Aborted                 qemu-x86_64 -m 4096 >>> -smp cores=4,sockets=1 -cpu host -machine pc-q35-4.0,accel=kvm -device >>> virtio-vga,virgl=on,xres=1280,yres=800 -display sdl,gl=on -device >>> intel-hda,id=sound0,msi=on -device >>> hda-micro,id=sound0-codec0,bus=sound0.0,cad=0 -device qemu-xhci,id=xhci >>> -device usb-tablet,bus=xhci.0 -net >>> nic,macaddr=52:54:00:12:34:62,model=e1000 -net >>> tap,ifname=$INTERFACE,script=no,downscript=no -drive >>> file=/media/daten2/image/lineageos.qcow2,if=virtio,index=1,media=disk,cache=none,aio=threads >>> >>> Set 'tap3' nonpersistent >>> >>> i have bicected the issue: >>> >>> towo:Defiant> git bisect good >>> b4e1a342112e50e05b609e857f38c1f2b7aafdc4 is the first bad commit >>> commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4 >>> Author: Paolo Bonzini >>> Date:   Tue Oct 27 08:44:23 2020 -0400 >>> >>>     vl: remove separate preconfig main_loop >>> >>>     Move post-preconfig initialization to the x-exit-preconfig. If >>> preconfig >>>     is not requested, just exit preconfig mode immediately with the QMP >>>     command. >>> >>>     As a result, the preconfig loop will run with accel_setup_post >>>     and os_setup_post restrictions (xen_restrict, chroot, etc.) >>>     already done. >>> >>>     Reviewed-by: Igor Mammedov >>>     Signed-off-by: Paolo Bonzini >>> >>>  include/sysemu/runstate.h |  1 - >>>  monitor/qmp-cmds.c        |  9 ----- >>>  softmmu/vl.c              | 95 >>> ++++++++++++++++++++--------------------------- >>>  3 files changed, 41 insertions(+), 64 deletions(-) >>> >>> Regards, >>> >>> Torsten Wohlfarth >>> >>> >>> >>