qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: David Gibson <dgibson@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic
Date: Wed, 26 Apr 2017 13:41:43 +0200	[thread overview]
Message-ID: <54cf73d4-b175-4c68-a881-c7f3a8acd758@twiddle.net> (raw)
In-Reply-To: <87fugvmoyq.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me>

On 04/26/2017 12:40 PM, Nikunj A Dadhania wrote:
>                           -> cc->cpu_exec_enter() = ppc_cpu_exec_enter()
>                              Sets env->reserve_addr = -1;

This is the bug.  We should be doing this in powerpc_excp instead.

I'm quite frankly surprised that we don't see this same failure with 
-singlestep, but I guess we usually stay in the cpu loop long enough.


r~

  parent reply	other threads:[~2017-04-26 11:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 10:43 [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic Richard Henderson
2017-04-25 11:21 ` Nikunj A Dadhania
2017-04-25 11:25   ` Richard Henderson
2017-04-26  7:06     ` aNikunj A Dadhania
2017-04-26 10:40       ` Nikunj A Dadhania
2017-04-26 11:23         ` Nikunj A Dadhania
2017-04-26 11:41         ` Richard Henderson [this message]
2017-04-26 11:38 ` Nikunj A Dadhania
2017-04-26 17:20 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54cf73d4-b175-4c68-a881-c7f3a8acd758@twiddle.net \
    --to=rth@twiddle.net \
    --cc=dgibson@redhat.com \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).