[PATCH] vfio/pci: Drop debug comentary from x-device-dirty-page-tracking

[PATCH] vfio/pci: Drop debug comentary from x-device-dirty-page-tracking

[Joao Martins]

The intent behind the x-device-dirty-page-tracking option is twofold:

1) development/testing in the presence of VFs with VF dirty page tracking

2) deliberately choosing platform dirty tracker over the VF one.

Item 2) scenario is useful when VF dirty tracker is not as fast as
IOMMU, or there's some limitations around it (e.g. number of them is
limited; aggregated address space under tracking is limited),
efficiency/scalability (e.g. 1 pagetable in IOMMU dirty tracker to scan
vs N VFs) or just troubleshooting. Given item 2 it is not restricted to
debugging, hence drop the debug parenthesis from the option description.

Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
---
 hw/vfio/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 64629c13b6fb..3496a0b6b099 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3531,7 +3531,7 @@ static void vfio_pci_dev_class_init(ObjectClass *klass, void *data)
     object_class_property_set_description(klass, /* 9.1 */
                                           "x-device-dirty-page-tracking",
                                           "Disable device dirty page tracking and use "
-                                          "container-based dirty page tracking (DEBUG)");
+                                          "container-based dirty page tracking");
     object_class_property_set_description(klass, /* 9.1 */
                                           "migration-events",
                                           "Emit VFIO migration QAPI event when a VFIO device "
-- 
2.43.5

Re: [PATCH] vfio/pci: Drop debug comentary from x-device-dirty-page-tracking

[Cédric Le Goater]

On 3/11/25 18:48, Joao Martins wrote:
> The intent behind the x-device-dirty-page-tracking option is twofold:
> 
> 1) development/testing in the presence of VFs with VF dirty page tracking
> 
> 2) deliberately choosing platform dirty tracker over the VF one.
> 
> Item 2) scenario is useful when VF dirty tracker is not as fast as
> IOMMU, or there's some limitations around it (e.g. number of them is
> limited; aggregated address space under tracking is limited),
> efficiency/scalability (e.g. 1 pagetable in IOMMU dirty tracker to scan
> vs N VFs) or just troubleshooting. Given item 2 it is not restricted to
> debugging, hence drop the debug parenthesis from the option description.
> 
> Signed-off-by: Joao Martins <joao.m.martins@oracle.com



Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/vfio/pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 64629c13b6fb..3496a0b6b099 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3531,7 +3531,7 @@ static void vfio_pci_dev_class_init(ObjectClass *klass, void *data)
>       object_class_property_set_description(klass, /* 9.1 */
>                                             "x-device-dirty-page-tracking",
>                                             "Disable device dirty page tracking and use "
> -                                          "container-based dirty page tracking (DEBUG)");
> +                                          "container-based dirty page tracking");
>       object_class_property_set_description(klass, /* 9.1 */
>                                             "migration-events",
>                                             "Emit VFIO migration QAPI event when a VFIO device "