From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVdAk-0001jU-Q9 for qemu-devel@nongnu.org; Wed, 11 Mar 2015 05:43:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVdAf-0003bg-Qs for qemu-devel@nongnu.org; Wed, 11 Mar 2015 05:43:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVdAf-0003bV-JP for qemu-devel@nongnu.org; Wed, 11 Mar 2015 05:43:21 -0400 Message-ID: <55000E14.3040007@redhat.com> Date: Wed, 11 Mar 2015 11:42:44 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1423064635-19045-1-git-send-email-marcel@redhat.com> <1423064635-19045-8-git-send-email-marcel@redhat.com> <54FF2EE0.9010401@suse.de> <20150310222233-mutt-send-email-mst@redhat.com> <54FF63F8.5030406@suse.de> <87twxsrnri.fsf@blackfin.pond.sub.org> <20150311084516.GA20804@redhat.com> In-Reply-To: <20150311084516.GA20804@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Markus Armbruster Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, jan.kiszka@siemens.com, Riku Voipio , cornelia.huck@de.ibm.com, qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, scottwood@freescale.com, pbonzini@redhat.com, leon.alrae@imgtec.com, =?windows-1252?Q?Andreas_F=E4rber?= , aurelien@aurel32.net On 03/11/2015 10:45 AM, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 08:34:09AM +0100, Markus Armbruster wrote: >> Andreas F=E4rber writes: >> >>> Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: >>>> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas F=E4rber wrote: >>>>> Hi, >>>>> >>>>> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: >>>>>> Fixes a QEMU crash when passing dump_guest_core parameter in comma= nd line. >>>>> >>>>> Explain that, please? >>>> >>>> Pls note the submission date. It's 1 month late to ask for >>>> basic clarifications. >>>> >>>> I've merged the patches, I'll fix up issues such as prettifying >>>> includes by adding patches on top. >>> >>> No, since the patch is not in qemu.git (it builds!) it is not too lat= e >>> to fix it, nor too late to ask why a patch that introduces a breakage >>> does what it does. >> >> Getting review that late is decidedly suboptimal, but no excuse to >> invoke maintainer privilege to ram the patch through unchanged. >> >> Cosmetic issues can be tidied up on top. The ongoing review may produ= ce >> nothing but cosmetic issues, but we don't know that, yet. > > Cool, review is good. What I wanted to say though is that I'm not > holding up a patchset that's been around for a month just because > of cosmetics and basic questions. > So I intend to send pull request this evening - I don't think we want t= o > live with known crashers any longer - crashes waste tester's time. > >> Commit messages can't be tidied up on top, and they're dirt cheap to >> improve right in place, so let's do that, please. >> >> [...] > > Sure. Marcel, can you pls supply the command line that > produces the crash? I'll include that. Sure you just have to use the option: qemu-bin ... -machine pc,dump-guest-core=3Don x86_64-softmmu/qemu-system-x86_64 -machine pc,dump-guest-core=3Don qemu-system-x86_64: qemu/util/qemu-option.c:387: qemu_opt_get_bool_helper= : Assertion `opt->desc && opt->desc->type =3D=3D QEMU_OPT_BOOL' failed. Aborted (core dumped) Thanks, Marcel >