From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVdCc-0002vh-FI for qemu-devel@nongnu.org; Wed, 11 Mar 2015 05:45:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVdCX-0004BW-8W for qemu-devel@nongnu.org; Wed, 11 Mar 2015 05:45:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVdCW-0004BN-VG for qemu-devel@nongnu.org; Wed, 11 Mar 2015 05:45:17 -0400 Message-ID: <55000E8A.2000805@redhat.com> Date: Wed, 11 Mar 2015 11:44:42 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1423064635-19045-1-git-send-email-marcel@redhat.com> <1423064635-19045-8-git-send-email-marcel@redhat.com> <54FF2EE0.9010401@suse.de> <20150310222233-mutt-send-email-mst@redhat.com> <54FF63F8.5030406@suse.de> In-Reply-To: <54FF63F8.5030406@suse.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?windows-1252?Q?Andreas_F=E4rber?= , "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, jan.kiszka@siemens.com, Riku Voipio , qemu-devel@nongnu.org, agraf@suse.de, scottwood@freescale.com, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net On 03/10/2015 11:36 PM, Andreas F=E4rber wrote: > Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: >> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas F=E4rber wrote: >>> Hi, >>> >>> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: >>>> Fixes a QEMU crash when passing dump_guest_core parameter in command= line. >>> >>> Explain that, please? >> >> Pls note the submission date. It's 1 month late to ask for >> basic clarifications. >> >> I've merged the patches, I'll fix up issues such as prettifying >> includes by adding patches on top. > > No, since the patch is not in qemu.git (it builds!) it is not too late > to fix it, nor too late to ask why a patch that introduces a breakage > does what it does. (Moving the info from the cover letter into the > commit message would've been a good idea, Marcel.) Hi Andreas, Agreed. Thanks, Marcel > > All QEMU patches are supposed to be bisectable. It's our job as > maintainers to build-test each. If you do that 1 month later, that's no= t > my fault. > > Regards, > Andreas >