From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1YVeKl-0006wZ-5C
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 06:57:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1YVeKh-0006ug-Pb
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 06:57:51 -0400
Received: from mail-pd0-f179.google.com ([209.85.192.179]:40451)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1YVeKh-0006uW-Jw
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 06:57:47 -0400
Received: by pdbfp1 with SMTP id fp1so10339586pdb.7
	for <qemu-devel@nongnu.org>; Wed, 11 Mar 2015 03:57:46 -0700 (PDT)
Message-ID: <55001FA2.1020908@ozlabs.ru>
Date: Wed, 11 Mar 2015 21:57:38 +1100
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1423999136-17320-1-git-send-email-mst@redhat.com>	<1423999136-17320-11-git-send-email-mst@redhat.com>	<54E1B8B0.5060705@redhat.com>
	<20150216113618.GB20667@redhat.com> <5500153E.3040505@ozlabs.ru>
In-Reply-To: <5500153E.3040505@ozlabs.ru>
Content-Type: text/plain; charset=koi8-r; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@amazon.com>, Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Chen,
	Tiejun" <tiejun.chen@intel.com>

On 03/11/2015 09:13 PM, Alexey Kardashevskiy wrote:
> Hi!
>
> This particular patch broke virtio-scsi in SLOF (ppc64-server firmware),
> QEMU just exits:

Oops, there was v3 and Nikunj asked there. Ignore this.


>
> Populating /pci@800000020000000/scsi@0
>         SCSI: Looking for devices
> qemu-system-ppc64: wrong size for virtio-scsi headers
>
>
> This is how I run it:
>
> -device virtio-scsi-pci,id=id3 \
> -drive id=id4,if=none,file=virtimg/rhel7_24GB.qcow2 \
> -device scsi-disk,id=id5,drive=id4
>
> It is bigendian, kvm or tcg.
>
>
> Any quick idea? Thanks :)
>
>
>
> On 02/16/2015 10:36 PM, Michael S. Tsirkin wrote:
>> On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote:
>>>
>>>
>>> On 15/02/2015 12:39, Michael S. Tsirkin wrote:
>>>> Drop duplicated code.
>>>>
>>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>>> ---
>>>>   include/hw/virtio/virtio-scsi.h | 120
>>>> +++-------------------------------------
>>>>   hw/scsi/virtio-scsi.c           |   1 +
>>>>   2 files changed, 10 insertions(+), 111 deletions(-)
>>>>
>>>> diff --git a/include/hw/virtio/virtio-scsi.h
>>>> b/include/hw/virtio/virtio-scsi.h
>>>> index bf17cc9..9bcda7e 100644
>>>> --- a/include/hw/virtio/virtio-scsi.h
>>>> +++ b/include/hw/virtio/virtio-scsi.h
>>>> @@ -14,6 +14,7 @@
>>>>   #ifndef _QEMU_VIRTIO_SCSI_H
>>>>   #define _QEMU_VIRTIO_SCSI_H
>>>>
>>>> +#include "standard-headers/sys/virtio_scsi.h"
>>>
>>> Why sys/?  It's linux/, let's keep it linux/.
>>>
>>> Paolo
>>
>> Peter requested this change: he felt having portable
>> headers under linux/ is confusing:
>>
>> http://mid.gmane.org/CAFEAcA8QFTWbBZSPjCKzEBBwWZojJL+LDKTPL_F=eCDpDHj=Zw@mail.gmail.com
>>
>>
>> Makes sense?
>>
>
>


-- 
Alexey