From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVg7Y-00050D-Ph for qemu-devel@nongnu.org; Wed, 11 Mar 2015 08:52:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVg7V-0004nO-9C for qemu-devel@nongnu.org; Wed, 11 Mar 2015 08:52:20 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:43911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVg7V-0004nI-3r for qemu-devel@nongnu.org; Wed, 11 Mar 2015 08:52:17 -0400 Received: by pdjp10 with SMTP id p10so11024662pdj.10 for ; Wed, 11 Mar 2015 05:52:16 -0700 (PDT) Message-ID: <55003A77.4090703@ozlabs.ru> Date: Wed, 11 Mar 2015 23:52:07 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1423999136-17320-1-git-send-email-mst@redhat.com> <1423999136-17320-11-git-send-email-mst@redhat.com> <54E1B8B0.5060705@redhat.com> <20150216113618.GB20667@redhat.com> <5500153E.3040505@ozlabs.ru> <20150311130340-mutt-send-email-mst@redhat.com> In-Reply-To: <20150311130340-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , Anthony Liguori , Nikunj A Dadhania , Alexander Graf , qemu-devel@nongnu.org, Stefan Hajnoczi , "Chen, Tiejun" , Cornelia Huck , Paolo Bonzini On 03/11/2015 11:04 PM, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 09:13:18PM +1100, Alexey Kardashevskiy wrote: >> Hi! >> >> This particular patch broke virtio-scsi in SLOF (ppc64-server firmware), >> QEMU just exits: >> >> Populating /pci@800000020000000/scsi@0 >> SCSI: Looking for devices >> qemu-system-ppc64: wrong size for virtio-scsi headers >> >> >> This is how I run it: >> >> -device virtio-scsi-pci,id=id3 \ >> -drive id=id4,if=none,file=virtimg/rhel7_24GB.qcow2 \ >> -device scsi-disk,id=id5,drive=id4 >> >> It is bigendian, kvm or tcg. >> >> >> Any quick idea? Thanks :) > > > Can you please try this patch: > mid.gmane.org/20150311101858-mutt-send-email-mst@redhat.com Tried, it helped. I also replied (the same) in the patch's mail thread. > > Thanks! > >> >> >> On 02/16/2015 10:36 PM, Michael S. Tsirkin wrote: >>> On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote: >>>> >>>> >>>> On 15/02/2015 12:39, Michael S. Tsirkin wrote: >>>>> Drop duplicated code. >>>>> >>>>> Signed-off-by: Michael S. Tsirkin >>>>> --- >>>>> include/hw/virtio/virtio-scsi.h | 120 +++------------------------------------- >>>>> hw/scsi/virtio-scsi.c | 1 + >>>>> 2 files changed, 10 insertions(+), 111 deletions(-) >>>>> >>>>> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h >>>>> index bf17cc9..9bcda7e 100644 >>>>> --- a/include/hw/virtio/virtio-scsi.h >>>>> +++ b/include/hw/virtio/virtio-scsi.h >>>>> @@ -14,6 +14,7 @@ >>>>> #ifndef _QEMU_VIRTIO_SCSI_H >>>>> #define _QEMU_VIRTIO_SCSI_H >>>>> >>>>> +#include "standard-headers/sys/virtio_scsi.h" >>>> >>>> Why sys/? It's linux/, let's keep it linux/. >>>> >>>> Paolo >>> >>> Peter requested this change: he felt having portable >>> headers under linux/ is confusing: >>> >>> http://mid.gmane.org/CAFEAcA8QFTWbBZSPjCKzEBBwWZojJL+LDKTPL_F=eCDpDHj=Zw@mail.gmail.com >>> >>> Makes sense? >>> >> >> >> -- >> Alexey -- Alexey