From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YVhQ8-0002pO-LG
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 10:15:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YVhQ7-0001fa-ED
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 10:15:36 -0400
Message-ID: <55004DE0.1040405@redhat.com>
Date: Wed, 11 Mar 2015 16:14:56 +0200
From: Marcel Apfelbaum <marcel@redhat.com>
MIME-Version: 1.0
References: <1426001534-7151-1-git-send-email-marcel@redhat.com>
	<1426083121.28125.28.camel@nilsson.home.kraxel.org>
In-Reply-To: <1426083121.28125.28.camel@nilsson.home.kraxel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 for-2.3 00/28] hw/pc: implement multiple
 primary busses for pc machines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, mst@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, alex.williamson@redhat.com, kevin@koconnor.net, qemu-ppc@nongnu.org, hare@suse.de, imammedo@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net

On 03/11/2015 04:12 PM, Gerd Hoffmann wrote:
> On Di, 2015-03-10 at 17:31 +0200, Marcel Apfelbaum wrote:
>> v4->v5:
>>   - Rebased on pci branch, tree:
>> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
>>   - Added PXB documentation (patch 28/28)
>>   - Addressed Gerd Hoffmann's review:
>>     - fix PXB behaviour if used with unsupported BIOS (patch 27/28)
>>   - Addressed Michael S. Tsirkin's review:
>>     - Removed assert in aml_index (patch 5/28)
>>     - Renamed pci_ functions to crs_ (patch 12/28)
>>     - used uint64_t variables instead of signed ones (patch 12/28)
>>     - Emit MEM/IO AML only for PXBs and i440fx (patch 26/28)
>>   - Addressed Shannon Zhao's review:
>>     - Changed build_append_int to  build_append_byte in aml_or (patch
>> 2/25)
>>   - Thanks to Igor and Kevin for reviews
>
Hi Gerd,

> Tested-by: Gerd Hoffmann <kraxel@gmail.com>
Appreciated!

>
> Possible improvement:  When you figure the devices behind the pxb are
> not initialized by the firmware (i.e. unmapped), you can try grab some
> address space not used by devices under root bus 0 and assign it to the
> pxb.  Then the linux kernel can initialize the devices even if the
> firmware did not.


Thanks for the idea, it is on my todo list after I'll make hotplug work for PXB buses.
Marcel

>
> [ Surely should be done incremental like hotplug support to not delay
>    this series even more ]
>
> cheers,
>    Gerd
>
>