Re: [Qemu-devel] [PATCH v4 1/5] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]

On 03/10/2015 06:14 AM, Quan Xu wrote:
> --Changes in v4:
>  -qapi schema enhancement.
>  -remove no need code.

Patch history belongs...

> 
> Signed-off-by: Quan Xu <quan.xu@intel.com>
> ---

...here.  It is useful to reviewers to know what changed since your last
submission, but not useful for the actual git history (where we will not
care if it took one revision or 20 on the mailing list before getting to
the one revision stored in git).  More tips:
http://wiki.qemu.org/Contribute/SubmitAPatch

>  configure        | 14 ++++++++++++++
>  hmp.c            |  2 ++
>  qapi-schema.json | 18 ++++++++++++++++--
>  qemu-options.hx  | 13 +++++++++++--
>  tpm.c            |  7 ++++++-
>  5 files changed, 49 insertions(+), 5 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -2854,9 +2854,11 @@
>  #
>  # @passthrough: TPM passthrough type
>  #
> +# @xenstubdoms: TPM xenstubdoms type (since 2.3)
> +#
>  # Since: 1.5
>  ##
> -{ 'enum': 'TpmType', 'data': [ 'passthrough' ] }
> +{ 'enum': 'TpmType', 'data': [ 'passthrough', 'xenstubdoms' ] }
>  
>  ##
>  # @query-tpm-types:
> @@ -2884,6 +2886,16 @@
>  { 'type': 'TPMPassthroughOptions', 'data': { '*path' : 'str',
>                                               '*cancel-path' : 'str'} }
>  
> +# @TPMXenstubdomsOptions:

Missing a '##' lead-in line.

> +#
> +# Information about the TPM xenstubdoms type
> +#
> +# Since: 2.3
> +##
> +{ 'type': 'TPMXenstubdomsOptions', 'data': {  } }
> +#
> +##
> +
>  ##

We don't usually have trailing '#' or '##' lines after a type declaration.

>  # @TpmTypeOptions:
>  #
> @@ -2894,7 +2906,9 @@
>  # Since: 1.5
>  ##
>  { 'union': 'TpmTypeOptions',
> -   'data': { 'passthrough' : 'TPMPassthroughOptions' } }
> +  'data': { 'passthrough' : 'TPMPassthroughOptions',
> +            'xenstubdoms' : 'TPMXenstubdomsOptions' } }
> +##
>  

We are already in soft freeze for 2.3, and this is a new feature.  Is it
still going to make it, or should you adjust this patch to say 'since 2.4'?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]