From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVo0Y-0006un-Tf for qemu-devel@nongnu.org; Wed, 11 Mar 2015 17:17:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVo0V-0003eE-LW for qemu-devel@nongnu.org; Wed, 11 Mar 2015 17:17:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVo0V-0003e2-E6 for qemu-devel@nongnu.org; Wed, 11 Mar 2015 17:17:35 -0400 Message-ID: <5500B0DD.6080904@redhat.com> Date: Wed, 11 Mar 2015 15:17:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1425989673-2812-1-git-send-email-quan.xu@intel.com> <1425989673-2812-2-git-send-email-quan.xu@intel.com> In-Reply-To: <1425989673-2812-2-git-send-email-quan.xu@intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jfBQgdXjUJJemAFp0wrjEXIfogWrT33bc" Subject: Re: [Qemu-devel] [PATCH v4 1/5] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Quan Xu , stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, kraxel@redhat.com, meyering@redhat.com, mjt@tls.msk.ru, sw@weilnetz.de, wei.liu2@citrix.com, stefanb@linux.vnet.ibm.com Cc: xen-devel@lists.xen.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jfBQgdXjUJJemAFp0wrjEXIfogWrT33bc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/10/2015 06:14 AM, Quan Xu wrote: > --Changes in v4: > -qapi schema enhancement. > -remove no need code. Patch history belongs... >=20 > Signed-off-by: Quan Xu > --- =2E..here. It is useful to reviewers to know what changed since your las= t submission, but not useful for the actual git history (where we will not care if it took one revision or 20 on the mailing list before getting to the one revision stored in git). More tips: http://wiki.qemu.org/Contribute/SubmitAPatch > configure | 14 ++++++++++++++ > hmp.c | 2 ++ > qapi-schema.json | 18 ++++++++++++++++-- > qemu-options.hx | 13 +++++++++++-- > tpm.c | 7 ++++++- > 5 files changed, 49 insertions(+), 5 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -2854,9 +2854,11 @@ > # > # @passthrough: TPM passthrough type > # > +# @xenstubdoms: TPM xenstubdoms type (since 2.3) > +# > # Since: 1.5 > ## > -{ 'enum': 'TpmType', 'data': [ 'passthrough' ] } > +{ 'enum': 'TpmType', 'data': [ 'passthrough', 'xenstubdoms' ] } > =20 > ## > # @query-tpm-types: > @@ -2884,6 +2886,16 @@ > { 'type': 'TPMPassthroughOptions', 'data': { '*path' : 'str', > '*cancel-path' : 'str'} }= > =20 > +# @TPMXenstubdomsOptions: Missing a '##' lead-in line. > +# > +# Information about the TPM xenstubdoms type > +# > +# Since: 2.3 > +## > +{ 'type': 'TPMXenstubdomsOptions', 'data': { } } > +# > +## > + > ## We don't usually have trailing '#' or '##' lines after a type declaration= =2E > # @TpmTypeOptions: > # > @@ -2894,7 +2906,9 @@ > # Since: 1.5 > ## > { 'union': 'TpmTypeOptions', > - 'data': { 'passthrough' : 'TPMPassthroughOptions' } } > + 'data': { 'passthrough' : 'TPMPassthroughOptions', > + 'xenstubdoms' : 'TPMXenstubdomsOptions' } } > +## > =20 We are already in soft freeze for 2.3, and this is a new feature. Is it still going to make it, or should you adjust this patch to say 'since 2.4= '? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jfBQgdXjUJJemAFp0wrjEXIfogWrT33bc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVALDdAAoJEKeha0olJ0NqPLAIAJACA7vz0Jk0BOlkt69pjCkC /9JNLyrXLiNVxuLJR93hHCmuPoGhF78Xjw5EZXJtCdNOp9ibW3BePeeqce4fvP81 /nIvS5Bz5Ecjxy8e78YdsoTajGSPddS+rq9yXbwWkvbuwnZRSlWbToaxzgSBd8K7 NVmGSO8M+bLcKennYh43xv8H917V3ARwfkkvF0XybU++5Tn4IH09bbrKEaiafiaf Yn1JNayNOjd6dy1yHvePVeA851QEAmRFTUVfm3xmlLDRmH1jjPBVDJ0yxA5zgY6/ WMsVHgBgAA2hS/bhRrneWkE2aPVyJZU3KqckaAxNaUiUTJIUWKSSPGpFnhrN2fg= =fcZV -----END PGP SIGNATURE----- --jfBQgdXjUJJemAFp0wrjEXIfogWrT33bc--