From: Gonglei <arei.gonglei@huawei.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: peter.huangpeng@huawei.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] vnc: fix segmentation fault when invalid vnc parameters are specified
Date: Thu, 12 Mar 2015 15:22:15 +0800 [thread overview]
Message-ID: <55013EA7.8040607@huawei.com> (raw)
In-Reply-To: <55013B1B.7040209@msgid.tls.msk.ru>
On 2015/3/12 15:07, Michael Tokarev wrote:
> 12.03.2015 06:59, arei.gonglei@huawei.com wrote:
>> +++ b/ui/vnc.c
>> @@ -3698,8 +3698,13 @@ QemuOpts *vnc_parse_func(const char *str)
>> {
>> QemuOptsList *olist = qemu_find_opts("vnc");
>> QemuOpts *opts = qemu_opts_parse(olist, str, 1);
>> - const char *id = qemu_opts_id(opts);
>> + const char *id = NULL;
>
> Useless initializer.
>
Okay, will fix, thanks.
Regards,
-Gonglei
> /mjt
>
>> + if (!opts) {
>> + return NULL;
>> + }
>> +
>> + id = qemu_opts_id(opts);
>
prev parent reply other threads:[~2015-03-12 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 3:59 [Qemu-devel] [PATCH] vnc: fix segmentation fault when invalid vnc parameters are specified arei.gonglei
2015-03-12 7:07 ` Michael Tokarev
2015-03-12 7:22 ` Gonglei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55013EA7.8040607@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=kraxel@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).