From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YVxTk-0007cz-JQ
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 03:24:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YVxTf-0006Nx-PX
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 03:24:24 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:31106)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YVxTf-0006MK-0M
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 03:24:19 -0400
Message-ID: <55013EA7.8040607@huawei.com>
Date: Thu, 12 Mar 2015 15:22:15 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1426132759-9980-1-git-send-email-arei.gonglei@huawei.com>
	<55013B1B.7040209@msgid.tls.msk.ru>
In-Reply-To: <55013B1B.7040209@msgid.tls.msk.ru>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vnc: fix segmentation fault when invalid
 vnc parameters are specified
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: peter.huangpeng@huawei.com, kraxel@redhat.com

On 2015/3/12 15:07, Michael Tokarev wrote:
> 12.03.2015 06:59, arei.gonglei@huawei.com wrote:
>> +++ b/ui/vnc.c
>> @@ -3698,8 +3698,13 @@ QemuOpts *vnc_parse_func(const char *str)
>>  {
>>      QemuOptsList *olist = qemu_find_opts("vnc");
>>      QemuOpts *opts = qemu_opts_parse(olist, str, 1);
>> -    const char *id = qemu_opts_id(opts);
>> +    const char *id = NULL;
> 
> Useless initializer.
> 
Okay, will fix, thanks.

Regards,
-Gonglei
> /mjt
> 
>> +    if (!opts) {
>> +        return NULL;
>> +    }
>> +
>> +    id = qemu_opts_id(opts);
>