[Qemu-devel] configure: enable kvm on x32

[Qemu-devel] configure: enable kvm on x32

[Michael Tokarev]

Here's a trivial change to enable kvm on x32 architecture.
I'm not 100% sure the result works correctly in all cases,
but this is a good start and in theory everything should
work.

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

diff --git a/configure b/configure
index 47048f0..d2e626e 100755
--- a/configure
+++ b/configure
@@ -5164,7 +5164,9 @@ case "$target_name" in
       \( "$target_name" = "ppcemb" -a "$cpu" = "ppc64" \) -o \
       \( "$target_name" = "mipsel" -a "$cpu" = "mips" \) -o \
       \( "$target_name" = "x86_64" -a "$cpu" = "i386"   \) -o \
-      \( "$target_name" = "i386"   -a "$cpu" = "x86_64" \) \) ; then
+      \( "$target_name" = "i386"   -a "$cpu" = "x86_64" \) -o \
+      \( "$target_name" = "x86_64" -a "$cpu" = "x32"   \) -o \
+      \( "$target_name" = "i386"   -a "$cpu" = "x32" \) \) ; then
       echo "CONFIG_KVM=y" >> $config_target_mak
       if test "$vhost_net" = "yes" ; then
         echo "CONFIG_VHOST_NET=y" >> $config_target_mak

Re: [Qemu-devel] configure: enable kvm on x32

[Peter Maydell]

On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Here's a trivial change to enable kvm on x32 architecture.
> I'm not 100% sure the result works correctly in all cases,
> but this is a good start and in theory everything should
> work.

Given the pessimism expressed in this comment, perhaps
we should delay this to 2.4 and when it's had more
testing?

-- PMM

Re: [Qemu-devel] configure: enable kvm on x32

[Michael Tokarev]

12.03.2015 10:16, Peter Maydell wrote:
> On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Here's a trivial change to enable kvm on x32 architecture.
>> I'm not 100% sure the result works correctly in all cases,
>> but this is a good start and in theory everything should
>> work.
> 
> Given the pessimism expressed in this comment, perhaps
> we should delay this to 2.4 and when it's had more
> testing?

There's no pessimism really.  It is a new arch for kvm, so
_something_ might not work.  In practice it works fairy well,
see https://bugs.debian.org/778737 -- at least debian can
be installed in x32 kvm.

And we don't lose anything really because it is a new arch.

That's why it was Cc'd -trivial.

Thanks,

/mjt

Re: [Qemu-devel] configure: enable kvm on x32

[Paolo Bonzini]

On 12/03/2015 09:06, Michael Tokarev wrote:
> 12.03.2015 10:16, Peter Maydell wrote:
>> On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
>>> Here's a trivial change to enable kvm on x32 architecture.
>>> I'm not 100% sure the result works correctly in all cases,
>>> but this is a good start and in theory everything should
>>> work.
>>
>> Given the pessimism expressed in this comment, perhaps
>> we should delay this to 2.4 and when it's had more
>> testing?
> 
> There's no pessimism really.  It is a new arch for kvm, so
> _something_ might not work.  In practice it works fairy well,
> see https://bugs.debian.org/778737 -- at least debian can
> be installed in x32 kvm.
> 
> And we don't lose anything really because it is a new arch.
> 
> That's why it was Cc'd -trivial.

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

... but I'm not going to test it.

Paolo