From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: pass .d file name to scripts/make_device_config.sh, fix makefile target
Date: Thu, 12 Mar 2015 16:40:13 +0100 [thread overview]
Message-ID: <5501B35D.9040208@redhat.com> (raw)
In-Reply-To: <20150312162331-mutt-send-email-mst@redhat.com>
On 12/03/2015 16:24, Michael S. Tsirkin wrote:
> > - $(call quiet-command,$(SHELL) $(SRC_PATH)/scripts/make_device_config.sh $@.tmp $<, " GEN $@.tmp")
> > + $(call quiet-command, \
> > + $(SHELL) $(SRC_PATH)/scripts/make_device_config.sh $< $*-config-devices.mak.d $@ > $@.tmp, " GEN $@.tmp")
> > $(call quiet-command, if test -f $@; then \
> > if cmp -s $@.old $@; then \
> Should this compare $@.old to $@.tmp?
>
It is trying to detect user-modified */config-devices.mak, so $@ is fine.
Paolo
prev parent reply other threads:[~2015-03-12 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 15:16 [Qemu-devel] [PATCH] build: pass .d file name to scripts/make_device_config.sh, fix makefile target Paolo Bonzini
2015-03-12 15:24 ` Michael S. Tsirkin
2015-03-12 15:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5501B35D.9040208@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).