From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YW5Dj-0003BJ-Fd
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 11:40:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YW5Dg-0005eP-61
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 11:40:23 -0400
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:41785)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YW5Df-0005eG-Ur
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 11:40:20 -0400
Received: by wiwl15 with SMTP id l15so21481424wiw.0
	for <qemu-devel@nongnu.org>; Thu, 12 Mar 2015 08:40:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5501B35D.9040208@redhat.com>
Date: Thu, 12 Mar 2015 16:40:13 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1426173388-11796-1-git-send-email-pbonzini@redhat.com>
	<20150312162331-mutt-send-email-mst@redhat.com>
In-Reply-To: <20150312162331-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] build: pass .d file name to
 scripts/make_device_config.sh, fix makefile target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org



On 12/03/2015 16:24, Michael S. Tsirkin wrote:
> > -	$(call quiet-command,$(SHELL) $(SRC_PATH)/scripts/make_device_config.sh $@.tmp $<, "  GEN   $@.tmp")
> > +	$(call quiet-command, \
> > +            $(SHELL) $(SRC_PATH)/scripts/make_device_config.sh $< $*-config-devices.mak.d $@ > $@.tmp, "  GEN   $@.tmp")
> >  	$(call quiet-command, if test -f $@; then \
> >  	  if cmp -s $@.old $@; then \
> Should this compare $@.old to $@.tmp?
> 

It is trying to detect user-modified */config-devices.mak, so $@ is fine.

Paolo