From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW6Cv-0000pP-Kx for qemu-devel@nongnu.org; Thu, 12 Mar 2015 12:43:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW6Cu-0001Id-O7 for qemu-devel@nongnu.org; Thu, 12 Mar 2015 12:43:37 -0400 Message-ID: <5501C22E.8070500@redhat.com> Date: Thu, 12 Mar 2015 10:43:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426172882-20084-1-git-send-email-armbru@redhat.com> In-Reply-To: <1426172882-20084-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ch5UQ3BFFcp3qjUb1uk6OcpHggav3ehJq" Subject: Re: [Qemu-devel] [PATCH] qemu-img: Avoid qerror_report_err() outside QMP handlers, again List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ch5UQ3BFFcp3qjUb1uk6OcpHggav3ehJq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/12/2015 09:08 AM, Markus Armbruster wrote: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. Replace by error_report_err(). >=20 > Commit 6936f29 cleaned that up in qemu-img.c, but two calls have crept > in since. Take care of them the same way. >=20 > Signed-off-by: Markus Armbruster > --- > qemu-img.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ch5UQ3BFFcp3qjUb1uk6OcpHggav3ehJq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVAcIuAAoJEKeha0olJ0Nq8csH/RU9Xl8z0tYSZoiqVPR/77og PZTpJ5sqdz5NNuZzteWbBMEqp7cWOPnF5al4wMZXjaiuk6A0X6YKj30wkSZ3oyGG A4Upqfn/iVUXjVr52blZsTpU8IA++r7xezlyHf0NGKJhPOWrdPCnOjwzfwQywBFL h4tdAF2uZexzUE7ZkUZ5PEj2jKNcqb6YgH5hUTz89l5cCy3wY3Sh+AruG7HqTTKL AKfij5Obv+89bYR1OAR/Wkn8yIKWq1J+V2tuXpuwOrurGQDCDFEAJWicxAtZJib2 w9cMnA+VkGL9y6mRG+g/KizYyDA6tp0IPioPJv+swpaT+E/m7jrSuhNqrqJ+Q0A= =/mlU -----END PGP SIGNATURE----- --Ch5UQ3BFFcp3qjUb1uk6OcpHggav3ehJq--