From: Eric Blake <eblake@redhat.com>
To: Richard Henderson <rth@twiddle.net>,
Markus Armbruster <armbru@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()
Date: Thu, 12 Mar 2015 10:45:58 -0600 [thread overview]
Message-ID: <5501C2C6.1060501@redhat.com> (raw)
In-Reply-To: <5501B0CC.3090500@twiddle.net>
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On 03/12/2015 09:29 AM, Richard Henderson wrote:
> On 02/25/2015 02:45 AM, Markus Armbruster wrote:
>> return 0x8000000000000000u >> (clz64(value - 1) - 1);
>
> I realize this was weeks ago, but it would certainly be preferable to shift a
> small constant left than a large constant right.
>
> Most RISC machines can't form 0x8000000000000000ull without loading 1 and then
> left shifting to start with. So end the end you're better off with
>
> return 1ull << (63 - clz64(value));
Since the value being shifted is a constant either way, can't gcc figure
out the equivalence and generate the optimal code to begin with? If
not, should it be opened as a gcc bug for potential optimization?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-12 16:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 12:23 [Qemu-devel] [PATCH v2] utils: Add pow2ceil() Alexey Kardashevskiy
2015-02-23 13:59 ` Markus Armbruster
2015-02-23 16:17 ` Eric Blake
2015-02-23 17:40 ` Markus Armbruster
2015-02-23 21:20 ` Eric Blake
2015-02-24 9:39 ` Markus Armbruster
2015-02-24 11:39 ` Peter Maydell
2015-02-24 13:09 ` Markus Armbruster
2015-02-25 0:40 ` Alexey Kardashevskiy
2015-02-25 10:45 ` Markus Armbruster
2015-03-12 15:29 ` Richard Henderson
2015-03-12 16:45 ` Eric Blake [this message]
2015-03-13 19:04 ` Richard Henderson
2015-03-13 7:33 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5501C2C6.1060501@redhat.com \
--to=eblake@redhat.com \
--cc=aik@ozlabs.ru \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).