From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW7Tz-0008T9-5e for qemu-devel@nongnu.org; Thu, 12 Mar 2015 14:05:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW7Tv-0003jM-Si for qemu-devel@nongnu.org; Thu, 12 Mar 2015 14:05:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW7Tv-0003jD-Ly for qemu-devel@nongnu.org; Thu, 12 Mar 2015 14:05:15 -0400 Message-ID: <5501D556.9070105@redhat.com> Date: Thu, 12 Mar 2015 19:05:10 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426178624-32638-1-git-send-email-afaerber@suse.de> <1426178624-32638-9-git-send-email-afaerber@suse.de> In-Reply-To: <1426178624-32638-9-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org On 12/03/2015 17:43, Andreas F=C3=A4rber wrote: > This cleans up the official /machine namespace. In particular > /machine/system and /machine/io as well as entries with non-sanitized > node names. Just a question: isn't it /machine/system[0] and /machine/io[0]? >=20 > Cc: Paolo Bonzini > Signed-off-by: Andreas F=C3=A4rber > --- > memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/memory.c b/memory.c > index 20f6d9e..ee3f2a8 100644 > --- a/memory.c > +++ b/memory.c > @@ -868,7 +868,7 @@ void memory_region_init(MemoryRegion *mr, > uint64_t size) > { > if (!owner) { > - owner =3D qdev_get_machine(); > + owner =3D container_get(qdev_get_machine(), "/unattached"); > } > =20 > object_initialize(mr, sizeof(*mr), TYPE_MEMORY_REGION); >=20 Acked-by: Paolo Bonzini