From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55205)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YWM93-0001S5-75
	for qemu-devel@nongnu.org; Fri, 13 Mar 2015 05:44:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YWM8z-0008Ae-UW
	for qemu-devel@nongnu.org; Fri, 13 Mar 2015 05:44:41 -0400
Message-ID: <5502B158.6060905@huawei.com>
Date: Fri, 13 Mar 2015 17:43:52 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1426225687-12104-1-git-send-email-zhaoshenglong@huawei.com>
	<87zj7h9u2o.fsf@linux.vnet.ibm.com>
In-Reply-To: <87zj7h9u2o.fsf@linux.vnet.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix
	out-of-bounds access
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, qemu-trivial@nongnu.org, mjt@tls.msk.ru, peter.huangpeng@huawei.com, shannon.zhao@linaro.org, pbonzini@redhat.com

On 2015/3/13 16:31, Aneesh Kumar K.V wrote:
> Shannon Zhao <zhaoshenglong@huawei.com> writes:
> 
>> It's detected by coverity. Fix out-of-bounds access of the function mp_dacl_listxattr.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>>  hw/9pfs/virtio-9p-posix-acl.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/9pfs/virtio-9p-posix-acl.c b/hw/9pfs/virtio-9p-posix-acl.c
>> index 803d9d9..09dad07 100644
>> --- a/hw/9pfs/virtio-9p-posix-acl.c
>> +++ b/hw/9pfs/virtio-9p-posix-acl.c
>> @@ -114,7 +114,7 @@ static ssize_t mp_dacl_listxattr(FsContext *ctx, const char *path,
>>      }
>>
>>      /* len includes the trailing NUL */
>> -    memcpy(value, ACL_ACCESS, len);
>> +    memcpy(value, ACL_DEFAULT, len);
>>      return 0;
>>  }
> 
> Applied.
> 
Thanks :-)

> Thanks
> -aneesh
> 
> 
> .
>