From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWOeX-0004Pg-AY for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:25:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWOeU-0008ER-De for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:25:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWOeU-0008EH-74 for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:25:18 -0400 Message-ID: <5502D728.5030904@redhat.com> Date: Fri, 13 Mar 2015 06:25:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1425883543-8852-1-git-send-email-zhang.zhanghailiang@huawei.com> <1425883543-8852-5-git-send-email-zhang.zhanghailiang@huawei.com> <5502C0C1.60903@redhat.com> In-Reply-To: <5502C0C1.60903@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QquoNkMwEQRNhd276PEoMo5LXluUivT5r" Subject: Re: [Qemu-devel] [PATCH v4 4/4] migration: Expose 'cancelling' status to user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , zhanghailiang , qemu-devel@nongnu.org Cc: quintela@redhat.com, libvir-list@redhat.com, armbru@redhat.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com, amit.shah@redhat.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QquoNkMwEQRNhd276PEoMo5LXluUivT5r Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/13/2015 04:49 AM, Paolo Bonzini wrote: >=20 >=20 > On 09/03/2015 07:45, zhanghailiang wrote: >> 'cancelling' status was introduced by commit 51cf4c1a, mainly to avoid= a=20 >> possible start of a new migration process while the previous one still= exists. >> But we didn't expose this status to user, instead we returned the 'act= ive' state. >> >> Here, we expose it to the user (such as libvirt), 'cancelling' status = only >> occurs for a short window before the migration aborts, so for users, >> if they cancel a migration process, it will observe 'cancelling' statu= s >> occasionally. >> >> Testing revealed that with older libvirt (anything 1.2.13 or less) wil= l >> print an odd error message if the state is seen, but that the migratio= n >> is still properly cancelled. Newer libvirt will be patched to recogniz= e >> the new state without the odd error message. >> >> Signed-off-by: zhanghailiang >> Reviewed-by: Eric Blake >> Cc: libvir-list@redhat.com >=20 > Why is this necessary? It simplifies qemu's job of reporting migration status information (qemu is no longer maintaining one set of states internally and a different set of states externally), and I already have the libvirt counterpart patch ready to go to gracefully accept the new state name. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QquoNkMwEQRNhd276PEoMo5LXluUivT5r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVAtcoAAoJEKeha0olJ0NqZMsIAIitMkRTrmG8eFpS+acdQVrE f2TWHms0iGDg//DEXcU45nAqqeZqEV3Q+UqqzznljYgDuyOWHJCwKzn6fXoHjAGZ Qe7hufwmbeyNZCnj8YHr2msjGNV+DA/JmT6iTrHUhXk9HqbZV6+iwXvmx0NhXkre GTJgrvwtnbONgI9UFbT2PH69CWnHH0y/55PuUSRZSiuwit4FLnn2nsxwtcnjXTWV wr3sQxer3gkQqRtDfPFgjigPyoQDiUTLBk4Yq+1VkV+u4RwbjjxM8hAeN+ga4y0u 4Mi2W+6j4eo7qWcCbp6wkNeCTpgsq0ND93E0O7j1OEr3LWucgG8zMGfeEaI3G6g= =Hr2P -----END PGP SIGNATURE----- --QquoNkMwEQRNhd276PEoMo5LXluUivT5r--