From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWOhv-0000ds-Ex for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:28:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWOhq-0001N8-6x for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:28:51 -0400 Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:44335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWOhq-0001MW-1F for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:28:46 -0400 Received: by wesp10 with SMTP id p10so22896450wes.11 for ; Fri, 13 Mar 2015 05:28:43 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5502D7F6.8020902@redhat.com> Date: Fri, 13 Mar 2015 13:28:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426228529-15969-1-git-send-email-famz@redhat.com> <20150313122329.GA9419@igalia.com> In-Reply-To: <20150313122329.GA9419@igalia.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block/throttle: Use host clock type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On 13/03/2015 13:23, Alberto Garcia wrote: > On Fri, Mar 13, 2015 at 02:35:29PM +0800, Fam Zheng wrote: > >> Throttle timers won't make any progress when VCPU is not running, >> which is prone to stall the request queue in cases like utils, >> qtest, suspending, and live migration, unless carefully handled. > > Yes, this can be easily reproduced by stopping the VM and starting a > block-commit job. If the I/O in that device is throttled then the job > will be stalled. That may be a different bug. Should jobs be subject to throttling at all? Paolo > Then there's also the situation that we discussed in IRC: if the > block-commit job is ongoing and then we stop the VM, then the rest of > the data will be committed bypassing the throttling settings. But > that's not related to these changes. > >> Signed-off-by: Fam Zheng >> --- >> block.c | 2 +- >> tests/test-throttle.c | 14 +++++++------- >> 2 files changed, 8 insertions(+), 8 deletions(-) > > Reviewed-By: Alberto Garcia > > Berto > >