From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWSyN-0005wP-Hz for qemu-devel@nongnu.org; Fri, 13 Mar 2015 13:02:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWSyJ-0002gh-QC for qemu-devel@nongnu.org; Fri, 13 Mar 2015 13:02:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWSyJ-0002gJ-Io for qemu-devel@nongnu.org; Fri, 13 Mar 2015 13:02:03 -0400 Message-ID: <550317FA.6090301@redhat.com> Date: Fri, 13 Mar 2015 18:01:46 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150227130939.11912.50660.stgit@PASHA-ISP> <20150227131131.11912.52470.stgit@PASHA-ISP> In-Reply-To: <20150227131131.11912.52470.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v10 18/24] replay: replay aio requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 27/02/2015 14:11, Pavel Dovgalyuk wrote: > This patch adds identifier to aio requests. ID is used for creating bottom > halves and identifying them while replaying. > The patch also introduces several functions that make possible replaying > of the aio requests. Out of curiosity, why did you use this approach instead of using a RR-specific block device backend (as you did for network, I think)? The backend could just store the data that is read in the RR file (or in a separate file that can be easily mmap-ed), and use a timer to trigger it at the right QEMU_CLOCK_VIRTUAL tick. I'm sure you considered something like this. Did you still get non-determinism? Paolo