From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWV0D-0006Lx-Hc for qemu-devel@nongnu.org; Fri, 13 Mar 2015 15:12:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWV0C-0006h1-HM for qemu-devel@nongnu.org; Fri, 13 Mar 2015 15:12:09 -0400 Message-ID: <5503367A.5090308@redhat.com> Date: Fri, 13 Mar 2015 13:11:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426269098-16043-1-git-send-email-armbru@redhat.com> In-Reply-To: <1426269098-16043-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="liEEVv1Ki2Vlivcr6kDieDbTr137PCfuf" Subject: Re: [Qemu-devel] [PATCH] block: Fix block-set-write-threshold not to use funky error class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, fromani@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --liEEVv1Ki2Vlivcr6kDieDbTr137PCfuf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/13/2015 11:51 AM, Markus Armbruster wrote: > Error classes are a leftover from the days of "rich" error objects. > New code should always use ERROR_CLASS_GENERIC_ERROR. More precisely, new code should use ERROR_CLASS_GENERIC_ERROR unless there is a good reason where a caller knowing a different error class is likely to react differently as a result (for example, with 'drive-mirror', libvirt DOES rely on QERR_DEVICE_NOT_FOUND as a witness that the command supports an optional 'top' argument, vs. ERROR_CLASS_GENERIC_ERROR to state that 'top' was still mandatory). But I agree that this situation is one unlikely to be where libvirt cares what error class was used. > Commit e246211 > added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. >=20 > Signed-off-by: Markus Armbruster > --- > block/write-threshold.c | 2 +- > qapi/block-core.json | 4 ---- > 2 files changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --liEEVv1Ki2Vlivcr6kDieDbTr137PCfuf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVAzZ6AAoJEKeha0olJ0NqVEoH/2r0CIS17EX8xaxUSFWpXbwm ms1FR3kDazC4qab7Z3+G7Q9t1jO2EuC6tHGiGtHixfLn1vY8WXYE9OhHe/C1YwXs BUNxtBAPHuSZO45UuaskEAH0L7FaREiDx5YeAE+gLbPYYPwM6ewcTi9NTKwcqwrH FLaYp8dr6Kwu9N298t1XciINEq4wevi7zZeGzn/zJdQtAtkA2tRKbYSECC6UD+qB IEVBJRbvSfpO0DzUUis3YSbSms8dGkTBphQhUgqtlcOqOtJW+leKnXJgtX55qViQ 1YHeCQM0+tdCtHDbYXJtvHSAbYBrDexgzc+uKwd+NreCDGEyBR1pzFjkiNWIbL8= =SVKe -----END PGP SIGNATURE----- --liEEVv1Ki2Vlivcr6kDieDbTr137PCfuf--