From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class
Date: Fri, 13 Mar 2015 13:15:22 -0600 [thread overview]
Message-ID: <5503374A.30205@redhat.com> (raw)
In-Reply-To: <8761a423hc.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On 03/13/2015 11:48 AM, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f
>> added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it.
"always" is a strong word; there are cases where alternate error classes
are useful. But I agree that this does not seem to be one of those
cases. Therefore:
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
>> ui/vnc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-13 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 17:43 [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class Markus Armbruster
2015-03-13 17:48 ` Markus Armbruster
2015-03-13 19:15 ` Eric Blake [this message]
2015-03-13 17:50 ` Patchew Tool
2015-03-13 17:56 ` Peter Maydell
2015-03-13 18:57 ` John Snow
2015-03-17 1:56 ` Fam Zheng
2015-03-17 7:49 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5503374A.30205@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).