From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWV3Q-0007rf-7G for qemu-devel@nongnu.org; Fri, 13 Mar 2015 15:15:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWV3M-00083P-UE for qemu-devel@nongnu.org; Fri, 13 Mar 2015 15:15:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWV3M-000829-KN for qemu-devel@nongnu.org; Fri, 13 Mar 2015 15:15:24 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2DJFNlB021393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 13 Mar 2015 15:15:24 -0400 Message-ID: <5503374A.30205@redhat.com> Date: Fri, 13 Mar 2015 13:15:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426268589-14756-1-git-send-email-armbru@redhat.com> <8761a423hc.fsf@blackfin.pond.sub.org> In-Reply-To: <8761a423hc.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xLtAn3lAEaxrx6PUseMJf7omp5lHF8BAJ" Subject: Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xLtAn3lAEaxrx6PUseMJf7omp5lHF8BAJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/13/2015 11:48 AM, Markus Armbruster wrote: > Markus Armbruster writes: >=20 >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f >> added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. "always" is a strong word; there are cases where alternate error classes are useful. But I agree that this does not seem to be one of those cases. Therefore: >=20 > Signed-off-by: Markus Armbruster >=20 >> ui/vnc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xLtAn3lAEaxrx6PUseMJf7omp5lHF8BAJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVAzdLAAoJEKeha0olJ0NqcCkH/jLsTksMenPzvexhu42VWAu6 135D50m4iD7IB4DuqEcfkSeE092h5I2Y3qmcC516IR3/1uSDXWMW9bkbFVXPrWhB uakype5g0PLwCSHSwgYVNGlwYs2T2JoYlvo9DvUM8Y6uozEvtutyThxRZ5Q+LyPB k2n/LGzHb6LMAbINQBlkwfwhZtfCoG8RxAqpCyyY3Cgi7rvtZCAE2xcjZZtp1zYC 01kxZXVXaOabbVWD4jhm7FX4cCWY31cSO7zdbLugFa8UI/aW1MaWEH7DHMsAMXtW g/ytS+panJ0ZANb179CsaBE6xu7eJTua4HRlNXE4RTmFS9v8b5tyHIObt4C3a08= =wmBL -----END PGP SIGNATURE----- --xLtAn3lAEaxrx6PUseMJf7omp5lHF8BAJ--