From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWVD4-0004fe-JS for qemu-devel@nongnu.org; Fri, 13 Mar 2015 15:25:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWVD1-0002kU-AH for qemu-devel@nongnu.org; Fri, 13 Mar 2015 15:25:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40282 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWVD1-0002hW-3M for qemu-devel@nongnu.org; Fri, 13 Mar 2015 15:25:23 -0400 Message-ID: <5503399F.5040307@suse.de> Date: Fri, 13 Mar 2015 20:25:19 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1426273797-11204-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1426273797-11204-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2] target-i386: Haswell-noTSX and Broadwell-noTSX CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: libvir-list@redhat.com, donald.d.dugger@intel.com, jun.nakajima@intel.com, Paolo Bonzini , Jiri Denemark Am 13.03.2015 um 20:09 schrieb Eduardo Habkost: > With the Intel microcode update that removed HLE and RTM, there will be > different kinds of Haswell and Broadwell CPUs out there: some that stil= l > have the HLE and RTM features, and some that don't have the HLE and RTM > features. On both cases people may be willing to use the pc-*-2.3 > machine-types. >=20 > So instead of making the CPU model results confusing by making it depen= d on the > machine-type, keep HLE and RTM on the existing Haswell and Broadwell CP= U > models, and introduce "Haswell-noTSX" and "Broadwell-noTSX" CPU models = later, > for people who have CPUs that don't have TSX feature available. >=20 > Eduardo Habkost (2): > Revert "target-i386: Disable HLE and RTM on Haswell & Broadwell" > target-i386: Haswell-noTSX and Broadwell-noTSX No objections from a generic CPU point of view. Only thing that comes to mind is whether it might make sense to hierarchically make Broadwell the parent type of Broadwell-noTSX, to avoid duplication. But then again we already have a lot of it. ;) Regards, Andreas > hw/i386/pc_piix.c | 4 --- > hw/i386/pc_q35.c | 4 --- > target-i386/cpu.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++-- > 3 files changed, 72 insertions(+), 10 deletions(-) --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)