From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWZqX-0001xZ-Ie for qemu-devel@nongnu.org; Fri, 13 Mar 2015 20:22:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWZqS-0005sq-JC for qemu-devel@nongnu.org; Fri, 13 Mar 2015 20:22:29 -0400 Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]:35953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWZqS-0005sh-Ap for qemu-devel@nongnu.org; Fri, 13 Mar 2015 20:22:24 -0400 Received: by pdbcz9 with SMTP id cz9so459075pdb.3 for ; Fri, 13 Mar 2015 17:22:23 -0700 (PDT) Sender: Richard Henderson Message-ID: <55037F3B.8020909@twiddle.net> Date: Fri, 13 Mar 2015 17:22:19 -0700 From: Richard Henderson MIME-Version: 1.0 References: <55032A6A.2080100@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-tilegx: Execute _start and reach to __libc_start_main successfully List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang , =?UTF-8?B?QW5kcmVhcyBGw6RyYmU=?= =?UTF-8?B?cg==?= , Chris Metcalf , Peter Maydell , Riku Voipio , "walt@tilera.com" Cc: qemu-devel On 03/13/2015 04:07 PM, Chen Gang wrote: >> UNARY_RRR_0_OPCODE_X0. >> >>> + if ((get_UnaryOpcodeExtension_X0(bundle) == 0x03) && !rsrc && !rdst) { >> >> FNOP_UNARY_OPCODE_X0. > > OK, thanks. > >> There are enough of these it's probably worth splitting >> out decode of this to its own function. >> > > OK, I will add gen_fnop() for it. I meant a function for decoding the unary opcodes, not fnop specifically. r~