From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60594)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1YWZNn-0001Er-Pj
	for qemu-devel@nongnu.org; Fri, 13 Mar 2015 19:52:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1YWZNj-0003n4-QT
	for qemu-devel@nongnu.org; Fri, 13 Mar 2015 19:52:47 -0400
Received: from mail.uni-paderborn.de ([131.234.142.9]:51821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1YWZNj-0003m1-K6
	for qemu-devel@nongnu.org; Fri, 13 Mar 2015 19:52:43 -0400
Message-ID: <550386B7.2070607@mail.uni-paderborn.de>
Date: Sat, 14 Mar 2015 00:54:15 +0000
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
MIME-Version: 1.0
References: <1426274817-25763-1-git-send-email-rth@twiddle.net>
In-Reply-To: <1426274817-25763-1-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tcg/optimize: Handle or r, a,
 a with constant a
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org


On 03/13/2015 07:26 PM, Richard Henderson wrote:
> As seen with ubuntu-5.10-live-powerpc.iso.
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>   tcg/optimize.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 067917c..37c1110 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -980,8 +980,11 @@ static void tcg_constant_folding(TCGContext *s)
>               if (temps_are_copies(args[1], args[2])) {
>                   if (temps_are_copies(args[0], args[1])) {
>                       tcg_op_remove(s, op);
> -                } else {
> +                } else if (temps[args[1]].state != TCG_TEMP_CONST) {
>                       tcg_opt_gen_mov(s, op, args, opc, args[0], args[1]);
> +                } else {
> +                    tcg_opt_gen_movi(s, op, args, opc,
> +                                     args[0], temps[args[1]].val);
>                   }
>                   continue;
>               }
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Cheers,
Bastian